From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488AbbJOSYX (ORCPT ); Thu, 15 Oct 2015 14:24:23 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44154 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752212AbbJOSYV (ORCPT ); Thu, 15 Oct 2015 14:24:21 -0400 Date: Thu, 15 Oct 2015 11:24:19 -0700 From: Stephen Boyd To: "Ivan T. Ivanov" Cc: "Ivan T. Ivanov" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gilad Avidov , Sagar Dharia Subject: Re: [PATCH] spmi-pmic-arb: support configurable number of peripherals Message-ID: <20151015182419.GH4558@codeaurora.org> References: <1442267672-11287-1-git-send-email-sboyd@codeaurora.org> <55F77451.9070900@codeaurora.org> <1442316018.15519.4.camel@mm-sol.com> <20150915182728.GA11715@codeaurora.org> <561EDAAC.6060800@codeaurora.org> <8EEAE898-347B-4CEA-BA4D-0C69897E18EB@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8EEAE898-347B-4CEA-BA4D-0C69897E18EB@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15, Ivan T. Ivanov wrote: > > > On Oct 15, 2015, at 1:43 AM, Stephen Boyd wrote: > > > > I have to take this back. I missed the part where some pmics are on > > slave id 2 or slave id 4, so this check isn't going to work. I've > > adjusted it to use sid % 2 instead and I'll resend these two patches, > > but I imagine to be more robust we're going to need to add a revid node > > to the DT under the SID that actually has it. Then we can search the > > child nodes for a revid compatible node and do the rev probing stuff. > > Ah, yes. We don’t use revision information for now. > I suppose we can just remove these reads until we need > this information? > True, we could just remove all the code and make it look for a revid node at some later time. But later would be soon because I'm working on patches to add the read/write/volatile regmap tables to this driver. I guess I'll just go all the way and do the revid node part. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project