From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753034AbbJOVe7 (ORCPT ); Thu, 15 Oct 2015 17:34:59 -0400 Received: from rcdn-iport-7.cisco.com ([173.37.86.78]:12752 "EHLO rcdn-iport-7.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbbJOVe5 (ORCPT ); Thu, 15 Oct 2015 17:34:57 -0400 X-IronPort-AV: E=Sophos;i="5.17,687,1437436800"; d="scan'208";a="36118688" Date: Thu, 15 Oct 2015 16:34:54 -0500 From: Dave Goodell To: Insu Yun Cc: umalhi@cisco.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu Subject: Re: [PATCH] usnic: correctly check failed allocation Message-ID: <20151015213453.GA77436@DGOODELL-M-F02A.cisco.com> References: <1444943715-31250-1-git-send-email-wuninsu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444943715-31250-1-git-send-email-wuninsu@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated-User: dgoodell Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 15, 2015 at 09:15:15PM +0000, Insu Yun wrote: > Since ib_alloc_device returns allocated memory address, not error, > it should be checked as IS_NULL, not IS_ERR_OR_NULL. > > Signed-off-by: Insu Yun Reviewed-by: Dave Goodell