From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753182AbbJOWAd (ORCPT <rfc822;w@1wt.eu>);
	Thu, 15 Oct 2015 18:00:33 -0400
Received: from mail.kapsi.fi ([217.30.184.167]:34540 "EHLO mail.kapsi.fi"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751483AbbJOWAc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 15 Oct 2015 18:00:32 -0400
Date: Fri, 16 Oct 2015 01:00:25 +0300
From: Mikko Rapeli <mikko.rapeli@iki.fi>
To: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Cc: linux-kernel@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        linux-api@vger.kernel.org
Subject: Re: [PATCH v4 23/79] rds.h: use __u8, __u16, __s16, __u32 and __s64
 from linux/types.h
Message-ID: <20151015220025.GG6104@lakka.kapsi.fi>
References: <1444888618-4506-1-git-send-email-mikko.rapeli@iki.fi>
 <1444888618-4506-24-git-send-email-mikko.rapeli@iki.fi>
 <20151015110614.GL948@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20151015110614.GL948@oracle.com>
X-SA-Exim-Connect-IP: 2001:1bc8:1004::1
X-SA-Exim-Mail-From: mikko.rapeli@iki.fi
X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 15, 2015 at 07:06:14AM -0400, Sowmini Varadhan wrote:
> On (10/15/15 07:56), Mikko Rapeli wrote:
> > Date: Thu, 15 Oct 2015 07:56:01 +0200
> > From: Mikko Rapeli <mikko.rapeli@iki.fi>
> > To: linux-kernel@vger.kernel.org
> > Cc: mikko.rapeli@iki.fi, "David S. Miller" <davem@davemloft.net>, Sowmini
> >  Varadhan <sowmini.varadhan@oracle.com>, linux-api@vger.kernel.org
> > Subject: [PATCH v4 23/79] rds.h: use __u8, __u16, __s16, __u32 and __s64
> >  from linux/types.h
> > X-Mailer: git-send-email 2.6.1
> > 
> > Fixes userspace compilation errors like:
> > 
> > linux/rds.h:96:2: error: unknown type name ‘uint8_t’
> 
> Can't you just include <stdint.h> in linux/rds.h? (similar to the
> fix for linux/rds)? It would reduce the deltas significantly, 
> and portable applications are likely to expect uint8_t etc anyway.

What kind of portability should exported userspace headers from Linux kernel
need?

Reviews to my previous changes NACKed <stdint.h> usage and
Documentation/CodingStyle chapter 5 says:

 (e) Types safe for use in userspace.

     In certain structures which are visible to userspace, we cannot
     require C99 types and cannot use the 'u32' form above. Thus, we
     use __u32 and similar types in all structures which are shared
     with userspace.

-Mikko