From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbbJPCZu (ORCPT ); Thu, 15 Oct 2015 22:25:50 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.232]:55924 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751082AbbJPCZt (ORCPT ); Thu, 15 Oct 2015 22:25:49 -0400 Date: Thu, 15 Oct 2015 22:25:45 -0400 From: Steven Rostedt To: Minfei Huang Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, mhuang@redhat.com, rostedt@goodmis.org Subject: Re: [REPOST PATCH] ftrace: Calculate the correct dyn_ftrace number to report to the userspace Message-ID: <20151015222545.45a22b7e@grimm.local.home> In-Reply-To: <1442420382-13130-1-git-send-email-mnfhuang@gmail.com> References: <1442420382-13130-1-git-send-email-mnfhuang@gmail.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Sep 2015 00:19:42 +0800 Minfei Huang wrote: > Now, ftrace only calculate the dyn_ftrace number in the adding > breakpoint loop, not in adding update and finish update loop. > > Calculate the correct dyn_ftrace, once ftrace reports the failure message > to the userspace. > Bah, your emails got lost in my Inbox. Sorry about that. I'll make an effort to look at this first thing tomorrow. [ Cc'ing myself to remind me ] -- Steve > Signed-off-by: Minfei Huang > --- > arch/x86/kernel/ftrace.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > index 8b7b0a5..311bcf3 100644 > --- a/arch/x86/kernel/ftrace.c > +++ b/arch/x86/kernel/ftrace.c > @@ -556,6 +556,7 @@ void ftrace_replace_code(int enable) > run_sync(); > > report = "updating code"; > + count = 0; > > for_ftrace_rec_iter(iter) { > rec = ftrace_rec_iter_record(iter); > @@ -563,11 +564,13 @@ void ftrace_replace_code(int enable) > ret = add_update(rec, enable); > if (ret) > goto remove_breakpoints; > + count++; > } > > run_sync(); > > report = "removing breakpoints"; > + count = 0; > > for_ftrace_rec_iter(iter) { > rec = ftrace_rec_iter_record(iter); > @@ -575,6 +578,7 @@ void ftrace_replace_code(int enable) > ret = finish_update(rec, enable); > if (ret) > goto remove_breakpoints; > + count++; > } > > run_sync();