From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932115AbbJPKlW (ORCPT ); Fri, 16 Oct 2015 06:41:22 -0400 Received: from mail-bl2on0071.outbound.protection.outlook.com ([65.55.169.71]:65166 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751968AbbJPKlU (ORCPT ); Fri, 16 Oct 2015 06:41:20 -0400 X-Greylist: delayed 3591 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Oct 2015 06:41:19 EDT Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NWB2QU-08-E7L-02 X-M-MSG: Date: Fri, 16 Oct 2015 17:06:18 +0800 From: Huang Rui To: Borislav Petkov , Aaron Lu CC: "Wan, Vincent" , "dmitry.torokhov@gmail.com" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mcuos.com@gmail.com" Subject: Re: [PATCH] input: i8042: add quirk to implement i8042 detect for AMD Message-ID: <20151016090617.GB17783@hr-amur2> References: <1445002020-12672-1-git-send-email-Vincent.Wan@amd.com> <20151016085808.GA32193@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20151016085808.GA32193@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(189002)(199003)(164054003)(24454002)(46406003)(97736004)(4001350100001)(87936001)(50986999)(189998001)(5001770100001)(92566002)(101416001)(5007970100001)(2950100001)(11100500001)(86362001)(5008740100001)(46102003)(19580395003)(76176999)(47776003)(54356999)(83506001)(106466001)(33656002)(50466002)(77096005)(33716001)(19580405001)(105586002)(23726002)(97756001)(64706001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR1201MB1040;H:atltwp02.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM3PR1201MB1040;2:zBuCFh4eqg2F9dM2gxHKSlPJAy92Dze8RwIz0KpsnAzxZP8SC6W2UuimtfBlkPj4J9Nh2xtV8Iw1VvbTT9jVX201hK/RRUwxvmd6hnEKe7EbzkFSdkhPcpEcAysLmoRbGHgM7SZdcKJ+SWWUHk4+Lw4Mp4Nwot8wagWdIfoOfn8=;3:L/9ImjR+i5aPafAniOdWYIfiNQ8cCKcXwNKjzRRNnvbkPQs791DrSc3HTeSY4oRcUcaINjvsp3r8yOgh41nxAu8y0sYikTo994oE6Na8KYXSrJ1y6yakJdDH55Ox6npdXv7LnYTL0R4twTHa9gFf7cT80ROKVkvqe9TUKPms8d6scHshMPtlAVWSCEP6lWmH25yYySow9lYP0UMQrAps50e8Uo6jg1PLwB8Zt84pWv16boTb5lrFF6haijKZr15Z;25:1pE7uB3ZPEgZOINV/8mPU6u61/CryeqhX051Z8GpCLzu/Y3+Br0HoWgjDsE9E9rWtAqdJcCkdLt7JotkH+6o2XZkYGjErqKR3DVrktpzKbsnLTERt9NAqhpmXMQDh2U6lHRi/Nd97yL6HPaXoDDcDjXA0Q35hRqKUSjsf/3fXuhyi19k5STtpZK4Dj2qsugDdVcDYwRLN0n4wXwIV/UyKjI6yQKlFy3UuIHoBPCT/H97+7Ca/rzWRU9aRISHWoppM4lCQA77RRrGwNzBiHOHjQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR1201MB1040; X-Microsoft-Exchange-Diagnostics: 1;DM3PR1201MB1040;20:Pp/Fwkd6ETFLViw4MuS7Hm3CRkSdny3DKzcarrOXWaAazRcz8R1rugtG9FvLNSqEUKdRtrqG02r1ZAQJCftenV4M80ecLELViFWQQT7K98g24KhZIyVcEXZtyxYEa5ORZUB6vv7er4uU8Oi/Fkm9InSvrDJIa/hA/hsVT6Lq23EB1TWmf9QReBdzUEQP9IfC+kVdT/OPPnjcjtsmZUn6kUShRjCXZAE7o/N2bxd0+tAYBWDF9djtO8IZ0YzQywkD7UeiReXh+N9oLfwC/DR7HngV10OG8vGFeNm8vla4iNFmFlvH6bZhlGePqpjsMfSF4vG9mVFSuf2YWhO/UrWqiej2ILYcZ4at09dAR539se1g+3zytOpTr/wrhGyMoRh7SCmuI76HxEPelydF1tahZjS/6heNmhnUy+3nkEiEvBOTlwspiCAtu4/9oYpaxBbbM+Ve5BW7iREHXIdWYnETuShITswcA2cL/6J4PePDe7gzOSJt1LRKdJkRN9kbADQ0;4:PV11HW1VRMaapVMQ+qTaKH8lutNhX7prfzw5sXUYqvnRjcavCBeKp9nGIol4TlMNVU/dMfJ+GlFT0BpZttkXgew+sE+RypHRAhCkMRMsuwqaxjeVSp5NWX3tJfMtAVhZFA42xpAUcCpmtD3Q2mVtCWAX7lXlfDKmWIUHI1Yh4DiNVeL2pEO7xb4bOnGZTd0cwmbeAbvK+d9BbIghbGAA8TbS7E9Y9vawwAQEh1z8ueH/hS75NSeCkKNkVQdmyZUi0wiiNAtdXS0PMgtioykaLXspZjkOaHnSQ/l1BitJDgQL+xWNKygSE9t5B2IjJ4L4pZ2sQQPl9aXi0qe1YRPOQax6ENOvnylBVbVnVLNwkl4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001);SRVR:DM3PR1201MB1040;BCL:0;PCL:0;RULEID:;SRVR:DM3PR1201MB1040; X-Forefront-PRVS: 0731AA2DE6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR1201MB1040;23:J8RK69/fa8V2lXAIl+2E/UoKQSWQxeX8ghbh9HV?= =?us-ascii?Q?dD5IwzXMtZ3BPbJ46nyuYzSNJhfBomdGF4VJxqYLNNvkeoXz12q6NiLamLdR?= =?us-ascii?Q?3tOlYE2yDDeUwn2cYq2vBcGrfd+A4J89k5+J1gJ8vKNtobQOLvprmk8RO2wo?= =?us-ascii?Q?GodKddwNQKdV9Mk7ewal+Ufc7C0yR+oQus/P3eKjFpHq+fjSgrngC3BoWx4Y?= =?us-ascii?Q?4zUdWqycbEBsb+9YUxDoHvWGiqM6U05he/EANGzDBuflq35MSYjnxJzc72vv?= =?us-ascii?Q?+hH7KLLQYH9oesy9mE58yfR5UPpTCHaAADd5mN1oTb21NvFEyyQ5hu6iDWiQ?= =?us-ascii?Q?5mMRe2ymDGywKaKgBqrAt/b0KV0lxIO8PKe7afWvfnYDrCOQdt2toAcwYHNo?= =?us-ascii?Q?D8+OD993XbuQMcniVzsLzJDf/6o16n/pSdY/8fw30HHpOx5DQ41n0FK34upM?= =?us-ascii?Q?y1eZbDLsP4ivSI1ErfmEQ15BkG8nNf/EIQCjGoYqlF7EIXx36jmtr3dAcYG5?= =?us-ascii?Q?zh8kivcrNsebZvPCsn4xZSEKyM7nb1wLvaXUr6kwdTMSklBY+mAP7sY7FFWU?= =?us-ascii?Q?AvDaVhEaWjXC62Tx3H7I6ffq5+yyNMDL9EzfU5E3pRZObdhYNZfodx61TCSX?= =?us-ascii?Q?9joo2e0wijKrnmgUyjW+yQF9Xk/NFpyUoz6tqxO+GhGJrqtwdLAWtyFVaI3P?= =?us-ascii?Q?MvqrbRn5Ctyw1BFlbl5NkgliNSIry7tetjZY22wpda7qOFIOY/J4pbwZjx6+?= =?us-ascii?Q?Gq6StkO3FNVDqjf7LeLodK7n8xUqtr+OJZcG8PxzBDIwgCTkfcWGAV85PNQ/?= =?us-ascii?Q?gTsDzXHFvLVED29KzfjLAeXjOD9+8mkHln4xRoAPly8yuC/W4OOAPbdr4l1B?= =?us-ascii?Q?sdTrDf9+lGN8rXWjMETEXsFXyuqM79djMszYYkfidjOWF4aWGUi31cJzrix8?= =?us-ascii?Q?N+kve/wgLQAyfuODHGWimo45tBTS706OuznKAxKsQM9nZUyy7NA35m8/GY4l?= =?us-ascii?Q?q8abTCfrTqdGndBob7cgXyXEQYochRa+vzyfBbzT0oMxwRQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR1201MB1040;5:+df8N5d40hfvppja7lhyX61X/j4Q8UsSXQK+aM+iCbuUL5vI6YHzFelJa28So50VQ5LGkdbKd9A7G6fEtlI79mjFIXK5j9kaCcIVVCMKQuzNM1p4e0rNGjN5LyXK8RLpemwAfRbiwWvUz6AyCACglQ==;24:lIDjZ6RKkkx/wDxnB/qxgmp2aNf1hdVOBRVBti1jBY7X4SsUbwMdpT3yvtAsEwsXiEf+IdtERYwWsI9LBZ8eg+YDLXZo/onUjHObVR1gjTc=;20:FVJbVoU2AP2dW2xlec/PcHiv+zsqzVtsOV1fFdqbMCOCfkjwZd+EE7ijIhhrtndMX75aoCDJTXnVH9+QFuqolmxGfgT4M+OjuVk6hi4f6FzHZT0UnLXjCauTZ+07rBy8me2LMYDFFDltqkICQzMrsGHTvlL5yQtPIGzP4lN3YppEbtr8jSl+HrTeaS9Ex/XQr36J1HKIBLOOKiv9ysWtqtQMQLoOHmFKVU6flzDXpX6ueV6qjW5poI3ergRCVcsh SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2015 09:08:57.3292 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR1201MB1040 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 16, 2015 at 04:58:09PM +0800, Borislav Petkov wrote: > On Fri, Oct 16, 2015 at 09:27:00AM -0400, Vincent Wan wrote: > > Detecting platform supports i8042 or not, AMD resorted to > > BIOS's FADT i8042 flag. > > > > Signed-off-by: Vincent Wan > > --- > > drivers/input/serio/i8042-x86ia64io.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h > > index c115565..bf3a605 100644 > > --- a/drivers/input/serio/i8042-x86ia64io.h > > +++ b/drivers/input/serio/i8042-x86ia64io.h > > @@ -9,6 +9,7 @@ > > > > #ifdef CONFIG_X86 > > #include > > +#include > > #endif > > > > /* > > @@ -1047,6 +1048,11 @@ static int __init i8042_platform_init(void) > > /* Just return if pre-detection shows no i8042 controller exist */ > > if (!x86_platform.i8042_detect()) > > return -ENODEV; > > + > > + if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) { > > Why the vendor check if you're accessing a bit defined in the ACPI spec? > Yeah, I have the same concern with AMD vendor check. :) Aaron, could you please help to check the impact at intel platfomrs if we remove this check? Thanks, Rui