From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753833AbbJPJ2l (ORCPT <rfc822;w@1wt.eu>);
	Fri, 16 Oct 2015 05:28:41 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:13345 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751512AbbJPJ2j (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 16 Oct 2015 05:28:39 -0400
X-IronPort-AV: E=Sophos;i="5.17,688,1437436800"; 
   d="scan'208";a="310810958"
Date: Fri, 16 Oct 2015 10:28:31 +0100
From: Wei Liu <wei.liu2@citrix.com>
To: Insu Yun <wuninsu@gmail.com>
CC: Ian Campbell <ian.campbell@citrix.com>, Wei Liu <wei.liu2@citrix.com>,
        <xen-devel@lists.xenproject.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Taesoo Kim <taesoo@gatech.edu>,
        Yeongjin Jang <yeongjin.jang@gatech.edu>,
        "Yun, Insu" <insu@gatech.edu>
Subject: Re: [PATCH] xen-netback: correctly check failed allocation
Message-ID: <20151016092831.GK32638@zion.uk.xensource.com>
References: <1444932148-15633-1-git-send-email-wuninsu@gmail.com>
 <CAGoFzNdCef+tutWgabSahHqV0rkC9FdNpjrQEsxk8GMeBA0TKQ@mail.gmail.com>
 <20151016090521.GJ32638@zion.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20151016090521.GJ32638@zion.uk.xensource.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 16, 2015 at 10:05:21AM +0100, Wei Liu wrote:
> On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote:
> > I changed patch with valid format.
> > 
> > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun <wuninsu@gmail.com> wrote:
> > 
> > > Since vzalloc can be failed in memory pressure,
> > > writes -ENOMEM to xenstore to indicate error.
> > >
> > > Signed-off-by: Insu Yun <wuninsu@gmail.com>
> > > ---
> > >  drivers/net/xen-netback/xenbus.c | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/net/xen-netback/xenbus.c
> > > b/drivers/net/xen-netback/xenbus.c
> > > index 929a6e7..56ebd82 100644
> > > --- a/drivers/net/xen-netback/xenbus.c
> > > +++ b/drivers/net/xen-netback/xenbus.c
> > > @@ -788,6 +788,12 @@ static void connect(struct backend_info *be)
> > >         /* Use the number of queues requested by the frontend */
> > >         be->vif->queues = vzalloc(requested_num_queues *
> > >                                   sizeof(struct xenvif_queue));
> > > +       if (!be->vif->queues) {
> > > +               xenbus_dev_fatal(dev, -ENOMEM,
> > > +                                "allocating queues");
> > > +               return;
> > >
> > 
> > I didn't use goto err, because another error handling is not required
> > 
> 
> It's recommended in kernel coding style to use "goto" style error
> handling. I personally prefer that to arbitrary return in function body,
> too.
> 
> It's not a matter of whether another error handling is required or not,
> it's about cleaner code that is easy to reason about and consistent
> coding style.
> 
> The existing code is not perfect, but that doesn't mean we should follow
> bad example.

And to be clear, I don't want to block this patch just because of this
coding style thing.  It's still an improvement and fix a real problem.
So:

Acked-by: Wei Liu <wei.liu2@citrix.com>