From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753732AbbJPK26 (ORCPT ); Fri, 16 Oct 2015 06:28:58 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60912 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbbJPK25 (ORCPT ); Fri, 16 Oct 2015 06:28:57 -0400 Date: Fri, 16 Oct 2015 11:28:46 +0100 From: Mark Brown To: Franklin S Cooper Jr Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, nsekhar@ti.com, ssantosh@kernel.org, iivanov@mm-sol.com, m-karicheri2@ti.com, iivanov.xz@gmail.com, andy.shevchenko@gmail.com, jarkko.nikula@linux.intel.com, hkallweit1@gmail.com Message-ID: <20151016102846.GJ14956@sirena.org.uk> References: <1444942305-24038-1-git-send-email-fcooper@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bEAlbH1hodbw2omC" Content-Disposition: inline In-Reply-To: <1444942305-24038-1-git-send-email-fcooper@ti.com> X-Cookie: Do you like "TENDER VITTLES"? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: Setup the master controller driver before setting the chipselect X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bEAlbH1hodbw2omC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 15, 2015 at 03:51:45PM -0500, Franklin S Cooper Jr wrote: > Some devices depend on the master controller driver setup function being > called before calling any chipselect functions. >=20 > Insure that this is done otherwise uninitialized structures may be > accessed causing a kernel panic. I think this is a sensible change but can we please have a better changelog - why is this the best thing to do rather than fixing the driver to not crash? There are a bunch of good reasons to do the master setup before asserting chip select but a driver crashing isn't one of them, it's not clear that this isn't a bug in the driver. --bEAlbH1hodbw2omC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWINFdAAoJECTWi3JdVIfQdk8H/iWU/1wgGtoajLHnPvMSEKkz zIRtLTy3VN5iDSz28FjtS7khCYybBQ0cUQ+rF8Tup+NwNjat50OVJJGwsvgwy206 GEqq28fr/vwP/Zy7NJT65m087QkU4lfbp2tXkbGrxSLrXNlfQ0ONIy4+uhPHQb4Y WJ+cyl4GL/FXgHW7J5k3EysA3I87PpISrixY5AboINbiiK5ScgAY0TfFpoP83qLp lv0/vaxJRFvRMFWhyD9E4GiWF0sAIWcM/svrR/yxhKZ8p+FH1ntBYnGtmhDFORma 693pvcNmOzwhNxmqw3nz0kPtgAU8J7jTsevU/IJQMKczB1Bzoop8pqxwdK4yeEk= =Q/Mc -----END PGP SIGNATURE----- --bEAlbH1hodbw2omC--