From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753780AbbJPKdq (ORCPT ); Fri, 16 Oct 2015 06:33:46 -0400 Received: from mail.skyhub.de ([78.46.96.112]:49050 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbbJPKdp (ORCPT ); Fri, 16 Oct 2015 06:33:45 -0400 Date: Fri, 16 Oct 2015 12:33:38 +0200 From: Borislav Petkov To: Andrey Ryabinin Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, Andrew Morton , Andy Lutomirski , Andrey Konovalov , Kostya Serebryany , Alexander Potapenko , kasan-dev , Denys Vlasenko , Andi Kleen , Dmitry Vyukov , Sasha Levin , Wolfram Gloger , "Paul E. McKenney" , Peter Zijlstra Subject: Re: [PATCH v4 1/2] compiler, atomics: Provide READ_ONCE_NOKSAN() Message-ID: <20151016103338.GE31612@pd.tnic> References: <1444739750-29241-1-git-send-email-aryabinin@virtuozzo.com> <1444988694-26043-1-git-send-email-aryabinin@virtuozzo.com> <1444988694-26043-2-git-send-email-aryabinin@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1444988694-26043-2-git-send-email-aryabinin@virtuozzo.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 16, 2015 at 12:44:53PM +0300, Andrey Ryabinin wrote: > Some code may perform racy by design memory reads. This could be > harmless, yet such code may produce KASAN warnings. > > To hide such accesses from KASAN this patch introduces > READ_ONCE_NOKSAN() macro. KASAN will not check the memory > accessed by READ_ONCE_NOKSAN(). The KernelThreadSanitizer (KTSAN) > is going to ignore it as well. Frankly, the "NOKSAN" suffix is too specific. I know, I know, I'm bikeshedding but what happens if yet another tool wants to be disabled from checking there and that tool is not *SAN? We rename again? So the "NOCHECK" suffix made much more sense, even if it was generic. IMNSVHO. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.