From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752690AbbJPOnN (ORCPT ); Fri, 16 Oct 2015 10:43:13 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:32944 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbbJPOnM (ORCPT ); Fri, 16 Oct 2015 10:43:12 -0400 Date: Fri, 16 Oct 2015 15:43:05 +0100 From: Mark Brown To: "Franklin S Cooper Jr." Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, nsekhar@ti.com, ssantosh@kernel.org, iivanov@mm-sol.com, m-karicheri2@ti.com, iivanov.xz@gmail.com, andy.shevchenko@gmail.com, jarkko.nikula@linux.intel.com, hkallweit1@gmail.com Message-ID: <20151016144305.GO14956@sirena.org.uk> References: <1444942305-24038-1-git-send-email-fcooper@ti.com> <20151016102846.GJ14956@sirena.org.uk> <56210966.3040501@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0FDNE3+7N8PCoNAN" Content-Disposition: inline In-Reply-To: <56210966.3040501@ti.com> X-Cookie: Do you like "TENDER VITTLES"? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: Setup the master controller driver before setting the chipselect X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0FDNE3+7N8PCoNAN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote: > Makes sense. How about something like this? > SPI controllers may need to be properly setup before chip selects > can be used. Therefore, wait until the spi controller has a chance > to perform their setup procedure before trying to use the chip > select. Yes, that's a lot better - there's also the fact that if we assert chip select before we've got the pins in a good state we may cause the device to see signals that confuse it as we change. --0FDNE3+7N8PCoNAN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWIQz4AAoJECTWi3JdVIfQj3gH/ReI3+qDUkiwk/HTyPRXu59i UqNJaM9bkQj/tfd6tsRZjXjp971IdaJ/VbbhlNBnAgj2fjA7cgTpfazR8OAbng+C MnMYgLDBqA2VFni2x9vS073OAgafhYW0FfVU4powF8k3AL3P5OVoe24ltd3sKxz6 5YT1fUkN9vRt+zmmOWAqHgVt5xaz/Y/K2dk7vu9bOlRcIT1bImg4e0lXo5oNTGGA UqwABCnziVaL9jElhSj26XyMw6RpVrNBSwN6SEUgSo1dkajLncT2D6LD4/Czs/xA Q6TAQYmTVRi66lyDxdCyTHVcnwtupwxbBjBQbdHoXLcvXmCFSlgnlUfp3Ajg/dQ= =v+Vw -----END PGP SIGNATURE----- --0FDNE3+7N8PCoNAN--