From: Sakari Ailus <sakari.ailus@iki.fi>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
pavel@ucw.cz, sakari.ailus@linux.intel.com, andrew@lunn.ch
Subject: Re: [PATCH v3 02/10] leds: Rename brightness_set_sync op to brightness_set_blocking
Date: Fri, 16 Oct 2015 18:34:23 +0300 [thread overview]
Message-ID: <20151016153422.GL26916@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <1444209048-29415-3-git-send-email-j.anaszewski@samsung.com>
On Wed, Oct 07, 2015 at 11:10:40AM +0200, Jacek Anaszewski wrote:
> The initial purpose of brightness_set_sync op, introduced along with
> the LED flash class extension, was to add a means for setting torch LED
> brightness as soon as possible, which couldn't have been guaranteed by
> brightness_set op. This patch renames the op to brightness_set_blocking,
> which describes its purpose in a more generic way. It is beneficial
> in view of the prospective changes in the LED core, aiming at removing
> the need for using work queues in LED class drivers that can sleep
> or use delays while setting brightness.
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2015-10-16 15:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 9:10 [PATCH v3 00/10] LED core improvements Jacek Anaszewski
2015-10-07 9:10 ` [PATCH v3 01/10] leds: core: Add two new LED_BLINK_ flags Jacek Anaszewski
2015-10-16 15:32 ` Sakari Ailus
2015-10-07 9:10 ` [PATCH v3 02/10] leds: Rename brightness_set_sync op to brightness_set_blocking Jacek Anaszewski
2015-10-16 15:34 ` Sakari Ailus [this message]
2015-10-07 9:10 ` [PATCH v3 03/10] leds: core: Add led_set_brightness_nosleep{nopm} functions Jacek Anaszewski
2015-10-07 9:10 ` [PATCH v3 04/10] leds: core: Use set_brightness_work for the blocking op Jacek Anaszewski
2015-10-16 15:43 ` Sakari Ailus
2015-10-18 7:06 ` Jacek Anaszewski
2015-10-07 9:10 ` [PATCH v3 05/10] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting Jacek Anaszewski
2015-10-07 9:10 ` [PATCH v3 06/10] Documentation: leds: Add description of brightness setting API Jacek Anaszewski
2015-10-16 15:36 ` Sakari Ailus
2015-10-18 7:08 ` Jacek Anaszewski
2015-10-07 9:10 ` [PATCH v3 07/10] leds: max77693: Remove work queue Jacek Anaszewski
2015-10-07 9:10 ` [PATCH v3 08/10] leds: aat1290: " Jacek Anaszewski
2015-10-07 9:10 ` [PATCH v3 09/10] leds: ktd2692: " Jacek Anaszewski
2015-10-07 9:10 ` [PATCH v3 10/10] media: flash: use led_set_brightness_sync for torch brightness Jacek Anaszewski
2015-10-07 10:49 ` Pavel Machek
2015-11-16 9:35 ` Jacek Anaszewski
2015-11-16 9:47 ` Sakari Ailus
2015-11-16 13:34 ` Jacek Anaszewski
2015-12-03 13:35 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016153422.GL26916@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=andrew@lunn.ch \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®