From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932582AbbJPQu3 (ORCPT ); Fri, 16 Oct 2015 12:50:29 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:33115 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753920AbbJPQu2 (ORCPT ); Fri, 16 Oct 2015 12:50:28 -0400 Date: Fri, 16 Oct 2015 17:50:23 +0100 From: Mark Brown To: Sascha Hauer Cc: linux-kernel@vger.kernel.org, Liam Girdwood , kernel@pengutronix.de, alkml@pengutronix.de Message-ID: <20151016165023.GT14956@sirena.org.uk> References: <1444733131-26995-1-git-send-email-s.hauer@pengutronix.de> <1444733131-26995-6-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jiz6jV+gGMQoj4lW" Content-Disposition: inline In-Reply-To: <1444733131-26995-6-git-send-email-s.hauer@pengutronix.de> X-Cookie: Do you like "TENDER VITTLES"? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 5/8] regulator: introduce regulator_get_voltage_floor X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jiz6jV+gGMQoj4lW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 13, 2015 at 12:45:28PM +0200, Sascha Hauer wrote: > + num_voltages = regulator_count_voltages(regulator); > + if (num_voltages < 0) > + return num_voltages; > + for (i = 0; i < num_voltages; i++) { > + now = _regulator_list_voltage(regulator, i, 0); > + if (now < 0) > + continue; > + if (now < best && now >= min_uV) > + best = now; > + } Why is this not a factoring out of existing code (indeed it is itself a reimplementation of regulator_map_voltage_iterate())? This will also be a substantial performance loss in cases where we have a known mapping function - we should use a map_voltage() operation if one exists like we do in _do_set_voltage(). That has logic to handle missing mapping functions as a transition measure, now I look at it we should probably remove that code and just require that the mapping function is set if appropriate. --jiz6jV+gGMQoj4lW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWISrOAAoJECTWi3JdVIfQaZAH/0FK55xLWceWzSTssLuxj2h1 by6GKA37ki1TrWQ8I38ANHi4820OVsobI89ZbOw2hRUER48KcBw1W3V7y5j9HhwB 4DbyE2bUr685VJNJWqMvd15eVftMulE0rCeDXjx0FH3aey3h1e19AzLPO+TXzXCP bSNAomD33MKOA+2kXkyHOdyXCBxfyWgGACbRG9XyQj5zgCbOqwAAJvrrt+q7qL2/ /4TpcUM/p66yF8EHvNMrM8THfhonpYQsMuifrLcf+6hJ078osBWq/ZALCktVTLnu 9BfW/D9bi516YLa8luI28qjytuNnVQUpyeMvGiqJloHvTDpVUWvfQ9rJl/Ydu4U= =ozOh -----END PGP SIGNATURE----- --jiz6jV+gGMQoj4lW--