From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932707AbbJPQz2 (ORCPT ); Fri, 16 Oct 2015 12:55:28 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:33126 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932101AbbJPQz0 (ORCPT ); Fri, 16 Oct 2015 12:55:26 -0400 Date: Fri, 16 Oct 2015 17:55:22 +0100 From: Mark Brown To: Sascha Hauer Cc: linux-kernel@vger.kernel.org, Liam Girdwood , kernel@pengutronix.de, alkml@pengutronix.de Message-ID: <20151016165522.GU14956@sirena.org.uk> References: <1444733131-26995-1-git-send-email-s.hauer@pengutronix.de> <1444733131-26995-7-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zHuqcmpxcmc4O8tc" Content-Disposition: inline In-Reply-To: <1444733131-26995-7-git-send-email-s.hauer@pengutronix.de> X-Cookie: Do you like "TENDER VITTLES"? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 6/8] regulator: core: Propagate voltage changes to supply regulators X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zHuqcmpxcmc4O8tc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 13, 2015 at 12:45:29PM +0200, Sascha Hauer wrote: > + best_supply_uV = regulator_get_voltage_floor(regulator, min_uV); > + if (best_supply_uV < 0) { > + ret = best_supply_uV; > + goto out2; > + } Now I look at the user here this is just the map voltage operation. We could even refactor... > ret = _regulator_do_set_voltage(rdev, min_uV, max_uV); > if (ret < 0) > goto out2; ...do_set_voltage() so that we only do the mapping once, though that gets tricky as we still support devices that don't have mapping configured :/ . Otherwise this looks good. --zHuqcmpxcmc4O8tc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWISv5AAoJECTWi3JdVIfQyBMIAIUz7wwwzpfVCLScisAjDwif 3bVkl/oweDns5zP0SGLr7UCKk2RAFtLLSi7BRmZPmaPC5GR4i6QgF6cyt4jEA9Dy u3q7wpxjtL5H5ASHGPnf26NV9vOmtgZrEHjvolB8+hYQBQZbSlNrSNhC9TXS01h4 gpf4LJ88o18X7RsaEbniY8l/JbxvAv0wSgXvtqMFP/dryBZbZo/H4Tey8gTgt5wO vcaDLsDMqEF84pSsqZ1wWjZekMPFE1VCpkyPm275AoMXeHx3QGNbihCe3bd2QFYA Anw5P1kEf2tqqdVjDlPnHmsN2RuFtvRcrZu38RWsO6G6vOxbzKJhy2m20LZwG/k= =kRaI -----END PGP SIGNATURE----- --zHuqcmpxcmc4O8tc--