From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932392AbbJPTqE (ORCPT ); Fri, 16 Oct 2015 15:46:04 -0400 Received: from mail.skyhub.de ([78.46.96.112]:55409 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932106AbbJPTqD (ORCPT ); Fri, 16 Oct 2015 15:46:03 -0400 Date: Fri, 16 Oct 2015 21:45:59 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Brian Gerst , Denys Vlasenko Subject: Re: [PATCH] x86/entry/32: Fix entry_INT80_32 to expect interrupts to be on Message-ID: <20151016194559.GB3590@pd.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 16, 2015 at 11:47:11AM -0700, Andy Lutomirski wrote: > When I rewrote entry_INT80_32, I thought that int80 was an interrupt > gate. It's a trap gate. *facepalm* > > Thanks to Brian Gerst for pointing out that it's better to change > the entry code than to change the gate type. > > Suggested-by: Brian Gerst > Reported-by: Borislav Petkov > Fixes: 150ac78d63af ("x86/entry/32: Switch INT80 to the new C syscall path") > Signed-off-by: Andy Lutomirski > --- > > I can reproduce Borislav's warning with an appropriate .config, and this > patch fixes it. I removed the Tested-by, because it's not the same fix > that Borislav tested. You can re-add it. Looks good. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.