From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbbJQGWr (ORCPT ); Sat, 17 Oct 2015 02:22:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60751 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbbJQGWp (ORCPT ); Sat, 17 Oct 2015 02:22:45 -0400 Date: Fri, 16 Oct 2015 23:22:43 -0700 From: Greg KH To: Sakshi Bansal Cc: jak@jak-linux.org, marvin24@gmx.de, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: fixed few coding style warnings Message-ID: <20151017062243.GA26616@kroah.com> References: <20151014140300.GA22848@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151014140300.GA22848@localhost.localdomain> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2015 at 07:33:00PM +0530, Sakshi Bansal wrote: > Fixed block comments usage of * on subsequent lines > > Signed-off-by: Sakshi Bansal > --- > drivers/staging/comedi/comedi.h | 181 +++++++++++++++++++-------------- > drivers/staging/comedi/comedi_pcmcia.h | 3 +- > drivers/staging/comedi/comedilib.h | 26 ++--- > 3 files changed, 120 insertions(+), 90 deletions(-) > > diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h > index 66edda1..31a43ee 100644 > --- a/drivers/staging/comedi/comedi.h > +++ b/drivers/staging/comedi/comedi.h > @@ -1,20 +1,20 @@ > /* > - include/comedi.h (installed as /usr/include/comedi.h) > - header file for comedi > + * include/comedi.h (installed as /usr/include/comedi.h) > + * header file for comedi > > - COMEDI - Linux Control and Measurement Device Interface > - Copyright (C) 1998-2001 David A. Schleef > + * COMEDI - Linux Control and Measurement Device Interface > + * Copyright (C) 1998-2001 David A. Schleef > > - This program is free software; you can redistribute it and/or modify > - it under the terms of the GNU Lesser General Public License as published by > - the Free Software Foundation; either version 2 of the License, or > - (at your option) any later version. > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU Lesser General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > Why are you leaving the blank lines alone? Either do it all or nothing, what you are doing here is not correct at all :( Hint, please leave these alone, there's nothing wrong with the existing format. sorry, greg k-h