From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752109AbbJQGYx (ORCPT ); Sat, 17 Oct 2015 02:24:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60760 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbbJQGYw (ORCPT ); Sat, 17 Oct 2015 02:24:52 -0400 Date: Fri, 16 Oct 2015 23:24:41 -0700 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Alexander Shishkin , Mathieu Poirier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] stm: add configfs dependency Message-ID: <20151017062441.GA26793@kroah.com> References: <5578991.YxAbTTycJA@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5578991.YxAbTTycJA@wuerfel> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 17, 2015 at 12:35:19AM +0200, Arnd Bergmann wrote: > There are three new stm modules, all of which use configfs for configuration. > If configfs is not part of the kernel, or is a loadable module while > the stm driver is builtin, we get a link error like: > > drivers/built-in.o: In function `stp_policy_node_drop': > drivers/hwtracing/stm/policy.c:232: undefined reference to `config_item_put' > drivers/built-in.o: In function `stp_policies_make': > drivers/hwtracing/stm/policy.c:352: undefined reference to `config_group_init_type_name' > drivers/built-in.o: In function `stp_policy_node_make': > drivers/hwtracing/stm/policy.c:215: undefined reference to `config_group_init_type_name' > > This adds explicit Kconfig dependencies to ensure configfs is present. > > Signed-off-by: Arnd Bergmann > --- > The patches are currently in Greg's char-misc tree, we should have > this one in the same branch. > > diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig > index 5a59a28cc3da..6df294fff1eb 100644 > --- a/drivers/hwtracing/stm/Kconfig > +++ b/drivers/hwtracing/stm/Kconfig > @@ -1,5 +1,6 @@ > config STM > tristate "System Trace Module devices" > + depends on CONFIGFS_FS It's better to do a select here, like other drivers do, I have a patch in my queue to do that, I'll queue it up now. thanks, greg k-h