From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, ak@linux.intel.com,
edumazet@google.com, acme@redhat.com
Subject: Re: [PATCH] perf/core: fix RCU issues with cgroup monitoring mode
Date: Sat, 17 Oct 2015 12:00:54 +0200 [thread overview]
Message-ID: <20151017100054.GF3816@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151017012811.GA18581@thinkpad>
On Sat, Oct 17, 2015 at 03:28:11AM +0200, Stephane Eranian wrote:
> static int __perf_cgroup_move(void *info)
> {
> struct task_struct *task = info;
> + rcu_read_lock();
> perf_cgroup_switch(task, PERF_CGROUP_SWOUT | PERF_CGROUP_SWIN);
> + rcu_read_unlock();
> return 0;
> }
On second thought, how can this be right? Surely the cgroup system has
cgroups stabilized over calling ->attach() ?
prev parent reply other threads:[~2015-10-17 10:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 1:28 Stephane Eranian
2015-10-17 9:56 ` Peter Zijlstra
2015-10-19 7:58 ` Stephane Eranian
2015-10-19 9:12 ` Peter Zijlstra
2015-10-26 19:27 ` Stephane Eranian
2015-10-26 20:20 ` Peter Zijlstra
2015-10-17 10:00 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151017100054.GF3816@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=edumazet@google.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome