From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbbJQS3M (ORCPT ); Sat, 17 Oct 2015 14:29:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37685 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbbJQS3L (ORCPT ); Sat, 17 Oct 2015 14:29:11 -0400 Date: Sat, 17 Oct 2015 11:29:11 -0700 From: Greg Kroah-Hartman To: Alexander Holler Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton , Russell King , Grant Likely Subject: Re: [PATCH 10/14] init: deps: IDs for annotated initcalls Message-ID: <20151017182911.GB28072@kroah.com> References: <1445102067-11519-1-git-send-email-holler@ahsoftware.de> <1445102067-11519-11-git-send-email-holler@ahsoftware.de> <20151017174550.GD27013@kroah.com> <56228B85.9040309@ahsoftware.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56228B85.9040309@ahsoftware.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 17, 2015 at 07:55:17PM +0200, Alexander Holler wrote: > Am 17.10.2015 um 19:45 schrieb Greg Kroah-Hartman: > >On Sat, Oct 17, 2015 at 07:14:23PM +0200, Alexander Holler wrote: > >>These patch contains the IDs for initcalls I've annotated. > >> > >>This patch is NOT meant for merging into mainline in its current form. > >> > >>It should be discussed about how to add these IDs and in which form, if > >>the feature ends up in mainline at all. > >> > >>E.g. it could make sense to split this file into several files in order > >>to avoid merge conflicts. > >> > >>It also might make sense to prefill this file with IDs for many drivers. > >> > >>E.g. the following script will use a modules.dep file to produce IDs for > >>modules. It's meant to be used on a very complete modules.dep build through > >>make allmodconfig && make -jN modules && make modules_install. > > > >A file like this is going to be a nightmare to maintain and ensure that > >it actually is correct, I don't see it as a viable solution, sorry. > > How often will drivers be added? The only changes on this file will happen > if a driver will be added and then just one ID will be added. Look at how many drivers we add every kernel release, it's a non-trivial amount. > As said above, the file could be filled with IDs for all existing modules, > regardless if they are already annotated. > > If that's a nightmare, I wonder what how you name the necessary stuff to > maintain the link order through Makefiles. There usually isn't a problem and the issue is that we link by subsystem, so somehow it's all working fairly well. thanks, greg k-h