From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753171AbbJSCpX (ORCPT <rfc822;w@1wt.eu>);
	Sun, 18 Oct 2015 22:45:23 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:48885 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752745AbbJSCpW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 18 Oct 2015 22:45:22 -0400
Date: Sun, 18 Oct 2015 20:01:37 -0700 (PDT)
Message-Id: <20151018.200137.982909998956019901.davem@davemloft.net>
To: arnd@arndb.de
Cc: huangdaode@hisilicon.com, joe@perches.com, liguozhu@hisilicon.com,
        Yisen.Zhuang@huawei.com, netdev@vger.kernel.org, linuxarm@huawei.com,
        salil.mehta@huawei.com, kenneth-lee-2012@foxmail.com,
        xuwei5@hisilicon.com, lisheng011@huawei.com,
        linux-kernel@vger.kernel.org, lipeng321@huawei.com
Subject: Re: [PATCH] net: hisilicon: add OF dependency
From: David Miller <davem@davemloft.net>
In-Reply-To: <4665385.OoIztz6y5m@wuerfel>
References: <1444967657-107994-1-git-send-email-huangdaode@hisilicon.com>
	<4665385.OoIztz6y5m@wuerfel>
X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 18 Oct 2015 19:45:21 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 16 Oct 2015 11:33:49 +0200

> The HNS MDIO driver fails to build on older ARM machines that are not
> yet converted to CONFIG_OF:
> 
> drivers/net/ethernet/hisilicon/hns_mdio.c: In function 'hns_mdio_bus_name':
> drivers/net/ethernet/hisilicon/hns_mdio.c:405:14: error: 'OF_BAD_ADDR' undeclared (first use in this function)
>   u64 taddr = OF_BAD_ADDR;
>               ^
> drivers/net/ethernet/hisilicon/hns_mdio.c:405:14: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/ethernet/hisilicon/hns_mdio.c:409:11: error: implicit declaration of function 'of_translate_address' [-Werror=implicit-function-declaration]
>    taddr = of_translate_address(np, addr);
>            ^
> 
> This clarifies the dependency to ensure we don't attempt to build these
> drivers without CONFIG_OF, but also adds a COMPILE_TEST alternative to
> give us better build coverage testing.
> 
> Build-tested on x86 as well to ensure this actually works.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.