From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752032AbbJRAOc (ORCPT ); Sat, 17 Oct 2015 20:14:32 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54580 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751268AbbJRAOb (ORCPT ); Sat, 17 Oct 2015 20:14:31 -0400 Date: Sun, 18 Oct 2015 02:14:28 +0200 From: Alexandre Belloni To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Alessandro Zummo , rtc-linux@googlegroups.com, kernel@pengutronix.de, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/4] rtc: pcf2127: fix reading uninitialized value on RTC_READ_VL ioctl Message-ID: <20151018001428.GV3421@piout.net> References: <1443777442-15920-1-git-send-email-u.kleine-koenig@pengutronix.de> <1443777442-15920-2-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443777442-15920-2-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/2015 at 11:17:19 +0200, Uwe Kleine-König wrote : > The flag reported on the RTC_READ_VL ioctl is only initialized when the > date is read out. So the voltage low value doesn't represent reality but > the status at the time the date was read (or 0 if the date was not read > yet). > > Moreover when userspace requests a value via an ioctl there is no added > benefit to also make a prosa representation of this (and other) values > appear in the kernel log so remove the calls to dev_info and the driver > data members to track their state. > > Signed-off-by: Uwe Kleine-König Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com