From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbbJRAPw (ORCPT ); Sat, 17 Oct 2015 20:15:52 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54614 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751758AbbJRAPv (ORCPT ); Sat, 17 Oct 2015 20:15:51 -0400 Date: Sun, 18 Oct 2015 02:15:50 +0200 From: Alexandre Belloni To: Arnd Bergmann Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sekhar Nori , Kevin Hilman , Miguel Aguilar Subject: Re: [PATCH] rtc: davinci: remove incorrect reference to probe function Message-ID: <20151018001550.GY3421@piout.net> References: <5677325.oZsHpDNL2Z@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5677325.oZsHpDNL2Z@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/2015 at 15:14:05 +0200, Arnd Bergmann wrote : > The davinci rtc driver uses the module_platform_driver_probe() > helper to call the probe function and mark it as __init, but > it also puts a reference into its davinci_rtc_driver function. > > This will crash if we ever get a deferred probe and the probe > function is called again after the init section has been removed. > kbuild warns about this: > > WARNING: vmlinux.o(.data+0x1aa2b4): Section mismatch in reference from the variable davinci_rtc_driver to the function .init.text:davinci_rtc_probe() > The variable davinci_rtc_driver references > the function __init davinci_rtc_probe() > > This patch removes the .probe callback from the platform driver, > which avoids those problems. > > Signed-off-by: Arnd Bergmann Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com