From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbbJRAaz (ORCPT ); Sat, 17 Oct 2015 20:30:55 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54720 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751581AbbJRAax (ORCPT ); Sat, 17 Oct 2015 20:30:53 -0400 Date: Sun, 18 Oct 2015 02:30:50 +0200 From: Alexandre Belloni To: Heiko Schocher Cc: linux-kernel@vger.kernel.org, Georg.Soffel@bosch-si.com, rtc-linux@googlegroups.com, Alessandro Zummo , devicetree@vger.kernel.org Subject: Re: [PATCH v4] rtc: pcf8563: add CLKOUT to common clock framework Message-ID: <20151018003050.GZ3421@piout.net> References: <1444995089-14493-1-git-send-email-hs@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444995089-14493-1-git-send-email-hs@denx.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/10/2015 at 13:31:29 +0200, Heiko Schocher wrote : > Add the clkout output clk to the common clock framework. > Disable the CLKOUT of the RTC after power-up. > After power-up/reset of the RTC, CLKOUT is enabled by default, > with CLKOUT enabled the RTC chip has 2-3 times higher power > consumption. > > Signed-off-by: Heiko Schocher > --- > > Changes in v4: > - add comments from Alexandre Belloni > - use devm_clk_register() instead of clk_register() > - rework Documentation > > Changes in v3: > - use CONFIG_COMMON_CLK for common clk framework > changes > > Changes in v2: > - add comments from Alexandre Belloni > - remove the DT property, instead > register for the CLKOUT a clk in the common > clk framework. The clk is disabled by default. > > Documentation/devicetree/bindings/rtc/pcf8563.txt | 25 ++++ > drivers/rtc/rtc-pcf8563.c | 170 +++++++++++++++++++++- > 2 files changed, 194 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com