From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754650AbbJRERO (ORCPT <rfc822;w@1wt.eu>);
	Sun, 18 Oct 2015 00:17:14 -0400
Received: from mga09.intel.com ([134.134.136.24]:17058 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754618AbbJRERJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 18 Oct 2015 00:17:09 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,695,1437462000"; 
   d="scan'208";a="829487593"
Date: Sat, 17 Oct 2015 22:17:08 -0600
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>, willy@linux.intel.com,
        Chuck Ebbert <cebbert.lkml@gmail.com>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: fs: out of bounds on stack in iov_iter_advance
Message-ID: <20151018041708.GA6500@linux.intel.com>
Mail-Followup-To: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>, willy@linux.intel.com,
	Chuck Ebbert <cebbert.lkml@gmail.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
References: <55CB5484.6080000@oracle.com>
 <20150815161338.4ea210ff@as>
 <55D1A6D4.3080605@gmail.com>
 <20150819054650.GD18890@ZenIV.linux.org.uk>
 <55FB75D0.7060403@oracle.com>
 <560C5469.5010704@oracle.com>
 <56229FEB.2040501@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56229FEB.2040501@oracle.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Oct 17, 2015 at 03:22:19PM -0400, Sasha Levin wrote:
> On 09/30/2015 05:30 PM, Sasha Levin wrote:
> > On 09/17/2015 10:24 PM, Sasha Levin wrote:
> >> On 08/19/2015 01:46 AM, Al Viro wrote:
> >>>> or mapping->a_ops->direct_IO() returned more
> >>>>> than 'count'.
> >>> 	Was there DAX involved?  ->direct_IO() in there is blkdev_direct_IO(),
> >>> which takes rather different paths in those cases...
> >>>
> >>
> >> So I've traced this all the way back to dax_io(). I can trigger this with:
> >>
> >> diff --git a/fs/dax.c b/fs/dax.c
> >> index 93bf2f9..2cdb8a5 100644
> >> --- a/fs/dax.c
> >> +++ b/fs/dax.c
> >> @@ -178,6 +178,7 @@ static ssize_t dax_io(struct inode *inode, struct iov_iter *iter,
> >>         if (need_wmb)
> >>                 wmb_pmem();
> >>
> >> +       WARN_ON((pos == start) && (pos - start > iov_iter_count(iter)));
> >>         return (pos == start) ? retval : pos - start;
> >>  }
> >>
> >> So it seems that iter gets moved twice here: once in dax_io(), and once again
> >> back at generic_file_read_iter().
> >>
> >> I don't see how it ever worked. Am I missing something?
> > 
> > Ping?
> 
> Ping?

I'll try and find time to look at this issue this week.  Sasha, do you have a
more targeted reproducer, or is still just the trinity fuzzer?