From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752001AbbJRT5i (ORCPT ); Sun, 18 Oct 2015 15:57:38 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35656 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbbJRT5h (ORCPT ); Sun, 18 Oct 2015 15:57:37 -0400 Date: Sun, 18 Oct 2015 20:57:19 +0100 From: Mark Brown To: Hans de Goede Cc: Chen-Yu Tsai , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Maxime Ripard , linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <20151018195719.GC14956@sirena.org.uk> References: <1444669458-5588-1-git-send-email-wens@csie.org> <561CAFE8.9080506@redhat.com> <20151014105556.GT14956@sirena.org.uk> <561E3D28.2090901@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zkS4nBu7xsy2hAaK" Content-Disposition: inline In-Reply-To: <561E3D28.2090901@redhat.com> X-Cookie: Do you like "TENDER VITTLES"? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH RFC 0/2] simplefb: Add regulator handling support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zkS4nBu7xsy2hAaK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 14, 2015 at 01:31:52PM +0200, Hans de Goede wrote: > I like your idea in your other mail where you suggest to actually > use foo-supply and bar-supply names in the simplefb node, and then have > some code simple iterate over all the properties and check for *-supply > properties, so that the proper, schematic matching names can be used. > But surely if we go this way having a helper for this so that others > can re-use that likely not entirely trivial code is a good idea ? Yeah. It's trying to come up with a way to do this that is easy to avoid abuse that's tricky. > One user which comes to mind immediately here is the generic mmc-pwrseq > driver. > I agree that we need to be careful to not use a helper like this too > much, but I do believe it will make sense to have it in some rare cases. > We can put a big warning in both the header declaring it and above > the implementation to use it scarcely. I'd rather have something that was visible in the code, not everyone reads the documentation especially not subsystem maintainers reviewing drivers that use APIs they're not familiar with. --zkS4nBu7xsy2hAaK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWI/meAAoJECTWi3JdVIfQ/KQH/AplrD5DclG0K6rHq14zyl3s 6TPBcR95e/52urDktvCDt9V5+3rOo9E+I46dnj8UGNgOCgGrt8J7iwuFh2+MYgVy NBoid3vgU+sXw4vlQBdIwOuqcMPjU8pBuzTEYIjixeGxyjjfh5+eO4Dm8NXMtTcL I0i84zkG3RTDIlHg90CpDkQ631FRPtgw7A9DaUBOMoSjqqoPtq1Ud06NAqHa2iD0 3y2M1BPJIgTGG2VtJu7peBTyIkTjKSWx2BMXW423/Bv0s1fh+tP3xS3RrLEU24na 47Wc0QpkEgpkAEpZW6Ht2Og2UTG44G1Gm6rROtGEzn8toYrjtfwSVPtpYT08p5g= =ETM+ -----END PGP SIGNATURE----- --zkS4nBu7xsy2hAaK--