From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbbJSJEL (ORCPT ); Mon, 19 Oct 2015 05:04:11 -0400 Received: from casper.infradead.org ([85.118.1.10]:50630 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbbJSJEK (ORCPT ); Mon, 19 Oct 2015 05:04:10 -0400 Date: Mon, 19 Oct 2015 11:04:05 +0200 From: Peter Zijlstra To: Ingo Molnar Cc: Catalin Marinas , "Paul E. McKenney" , Will Deacon , Linux Kernel Mailing List , Oleg Nesterov , Linus Torvalds , Andrew Morton Subject: Re: Q: schedule() and implied barriers on arm64 Message-ID: <20151019090405.GG3816@twins.programming.kicks-ass.net> References: <20151016151830.GZ3816@twins.programming.kicks-ass.net> <20151016160422.GQ3910@linux.vnet.ibm.com> <20151016161608.GA3816@twins.programming.kicks-ass.net> <20151016190648.GC3816@twins.programming.kicks-ass.net> <20151019070604.GA17855@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151019070604.GA17855@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 19, 2015 at 09:06:05AM +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > In any case, its all moot now, since Paul no longer requires schedule() to imply > > a full barrier. > > > > [...] > > Nevertheless from a least-surprise POV it might be worth guaranteeing it, because > I bet there's tons of code that assumes that schedule() is a heavy operation and > it's such an easy mistake to make. Since we are so close to having that guarantee, > we might as well codify it? > > Just like system calls are assumed to be barriers in general - Are they? I know they are on some platforms, but I'm not sure we've audited them all and established this. > and system calls are more lightweight than schedule() ... Hopefully, although if you enable nohz_full there's a fair chance to reverse that :-)