From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753577AbbJSNNJ (ORCPT ); Mon, 19 Oct 2015 09:13:09 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37247 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbbJSNNE (ORCPT ); Mon, 19 Oct 2015 09:13:04 -0400 Date: Mon, 19 Oct 2015 14:12:54 +0100 From: Mark Brown To: Alexander Holler Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton , Russell King , Grant Likely Message-ID: <20151019131254.GG14956@sirena.org.uk> References: <1445102067-11519-1-git-send-email-holler@ahsoftware.de> <1445102067-11519-11-git-send-email-holler@ahsoftware.de> <20151017174550.GD27013@kroah.com> <56228B85.9040309@ahsoftware.de> <20151017182911.GB28072@kroah.com> <56229794.3070402@ahsoftware.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="trRLnZT3leHHTjS+" Content-Disposition: inline In-Reply-To: <56229794.3070402@ahsoftware.de> X-Cookie: Do you like "TENDER VITTLES"? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 10/14] init: deps: IDs for annotated initcalls X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --trRLnZT3leHHTjS+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 17, 2015 at 08:46:44PM +0200, Alexander Holler wrote: > Am 17.10.2015 um 20:29 schrieb Greg Kroah-Hartman: > >On Sat, Oct 17, 2015 at 07:55:17PM +0200, Alexander Holler wrote: > >>Am 17.10.2015 um 19:45 schrieb Greg Kroah-Hartman: > >>>A file like this is going to be a nightmare to maintain and ensure that > >>>it actually is correct, I don't see it as a viable solution, sorry. > >>How often will drivers be added? The only changes on this file will hap= pen > >>if a driver will be added and then just one ID will be added. > >Look at how many drivers we add every kernel release, it's a non-trivial > >amount. > I still don't see your problem. As long as the IDs in the enum are ordered > according to the directories, there won't be more merge conflicts than in > the Makefile or Kconfig for that directory. And as mentioned, it's e.g. > possible to split the one file into multiple ones, e.g. >=20 > enum driver_ids { >=20 > #include "foo" > #include "bar" >=20 > }; >=20 > Of cource, the content of foo and bar might look a bit unusual. If it's a purely mechanical thing we really ought to be able to arrange for it to be generated during the build rather than have to have more typing. If the values matter then people have to think about what they are which is more effort and rather indirect. > It's just that I didn't thought much about another solution, and the time > I've spend to think about something else which provides a usable ID, didn= 't > end in a solution. So I would be happy if someone else would offer an ide= a. A checksum of the driver name? --trRLnZT3leHHTjS+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWJOxVAAoJECTWi3JdVIfQwM8H+QGW93qHWWqH9tGsi0Bk7Q14 Gn9/hU+1srzpJ/ZwHipsE5z13hA+X32TShIumzaduBu+u153M9VvyL593Kezp4XJ pR/agEzNNNDpM7XVukuRAEEew+Nohc9RmFhGNgpPvu1Mtp+DB1Y4vpbRPH/8I4tX 5X9rBP+8Cx5Ohir1RYheVt4cdocNFOgp3fpZHAuQwQXi+Qs2kMkzP2AnALS5vvjV AicDi3Aj2n067yNOn/ak4OFzAe9tWvNlSMfcbxSHFQRAG9ZHziByUT7XrWcni7hj E2UN91PE7k+HctOEAFL2pF2z43Vri80HaqFctHtGGfdD0VROwTwbEGSb83GFPgI= =hmx2 -----END PGP SIGNATURE----- --trRLnZT3leHHTjS+--