From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093AbbJSPOh (ORCPT ); Mon, 19 Oct 2015 11:14:37 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:47965 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753047AbbJSPOg (ORCPT ); Mon, 19 Oct 2015 11:14:36 -0400 Date: Mon, 19 Oct 2015 16:14:18 +0100 From: Russell King - ARM Linux To: Liviu Dudau Cc: David Airlie , Daniel Vetter , Philipp Zabel , Mark Yao , Heiko Stuebner , dri-devel , linux-rockchip , LAKML , LKML Subject: Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters. Message-ID: <20151019151418.GG32532@n2100.arm.linux.org.uk> References: <1445267270-23126-1-git-send-email-Liviu.Dudau@arm.com> <1445267270-23126-2-git-send-email-Liviu.Dudau@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445267270-23126-2-git-send-email-Liviu.Dudau@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 19, 2015 at 04:07:47PM +0100, Liviu Dudau wrote: > A lot of component based DRM drivers use a variant of the same code > as the probe function. They bind the crtc ports in the first iteration > and then scan through the child nodes and bind the encoders attached > to the remote endpoints. Factor the common code into a separate > function called drm_of_component_probe() in order to increase code > reuse. Thanks, this now looks perfect. Acked-by: Russell King -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.