From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754350AbbJSPWA (ORCPT ); Mon, 19 Oct 2015 11:22:00 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:36570 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754277AbbJSPVn (ORCPT ); Mon, 19 Oct 2015 11:21:43 -0400 Date: Tue, 20 Oct 2015 00:21:34 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Wang Nan , acme@kernel.org, ast@plumgrid.com, brendan.d.gregg@gmail.com, a.p.zijlstra@chello.nl, daniel@iogearbox.net, dsahern@gmail.com, hekuang@huawei.com, jolsa@kernel.org, lizefan@huawei.com, masami.hiramatsu.pt@hitachi.com, paulus@samba.org, linux-kernel@vger.kernel.org, pi3orama@163.com, xiakaixu@huawei.com Subject: Re: [PATCH 21/31] perf test: Enforce LLVM test, add kbuild test Message-ID: <20151019152134.GB14297@danjae.kornet> References: <1444826502-49291-1-git-send-email-wangnan0@huawei.com> <1444826502-49291-22-git-send-email-wangnan0@huawei.com> <20151019144231.GA14297@danjae.kornet> <20151019145312.GA2359@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151019145312.GA2359@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Mon, Oct 19, 2015 at 12:53:12PM -0200, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 19, 2015 at 11:42:31PM +0900, Namhyung Kim escreveu: > > Hi, > > > > On Wed, Oct 14, 2015 at 12:41:32PM +0000, Wang Nan wrote: > > > This patch enforces existing LLVM test, makes it compile more than one > > > BPF source file. The compiled results are stored, can be used for other > > > testcases. Except the first testcase (named LLVM_TESTCASE_BASE), failures > > > of other test cases are not considered as failure of the whole test. > > > > > > Adds a kbuild testcase to check whether kernel headers can be correctly > > > found. > > > > > > For example: > > > > > > # perf test LLVM > > > > > > 38: Test LLVM searching and compiling : (llvm.kbuild-dir can be fixed) Ok > > > > IMHO it'd be better to keep the test result simply as either "Ok" or > > "FAILED" and provide details with -v option. > > "Skipped" looks more natural here, with the reason for it skipping being shown > only with -v. Agreed. > > Ingo made some comments about 'perf test' output recently, have you read that? Nop, sorry. I'll check it (and it'd be great it you could give me the link :) > > > Anyway I found the tracepoint error message is annoying in the current > > You mean all these warnings: > > [root@zoo ~]# perf test "parse event" > 5: parse events tests : Warning: [sunrpc:xprt_lookup_rqst] function __builtin_constant_p not defined > Warning: [sunrpc:xprt_transmit] function __builtin_constant_p not defined > Warning: [sunrpc:xprt_complete_rqst] function __builtin_constant_p not defined > > Warning: [xen:xen_mmu_set_pud] function sizeof not defined > Warning: [xen:xen_mmu_set_pgd] function sizeof not defined > Warning: [xen:xen_mmu_ptep_modify_prot_start] function sizeof not defined > Warning: [xen:xen_mmu_ptep_modify_prot_commit] function sizeof not defined > Ok > [root@zoo ~]# > > i.e. making those warnings appear only under 'perf test -v'? Cool! Will send the fix soon! Thanks, Namhyung