From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753960AbbJSQIz (ORCPT ); Mon, 19 Oct 2015 12:08:55 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37488 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753670AbbJSQIx (ORCPT ); Mon, 19 Oct 2015 12:08:53 -0400 Date: Mon, 19 Oct 2015 17:08:42 +0100 From: Mark Brown To: Takashi Iwai Cc: Dan Williams , Liam Girdwood , Jeeja KP , linux-arm-kernel@lists.infradead.org, Jaroslav Kysela , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20151019160842.GF32054@sirena.org.uk> References: <20151009221537.32203.5867.stgit@dwillia2-desk3.jf.intel.com> <20151009221635.32203.30755.stgit@dwillia2-desk3.jf.intel.com> <20151019152641.GC32054@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tmoQ0UElFV5VgXgH" Content-Disposition: inline In-Reply-To: X-Cookie: HUGH BEAUMONT died in 1982!! User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tmoQ0UElFV5VgXgH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 19, 2015 at 05:34:48PM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > On Fri, Oct 09, 2015 at 06:16:36PM -0400, Dan Williams wrote: > > > In preparation for deprecating ioremap_cache() convert its usage in > > > skl-nhlt to memremap. > > > -void __iomem *skl_nhlt_init(struct device *dev) > > > +void *skl_nhlt_init(struct device *dev) > > Why are we loosing the annotation here? > It's the exact purpose of this patchset, as far as I understand. > memremap() allows the driver accessing the mapped memory just like a > normal memory unlike ioremap(). There's no mention of what the purpose of the conversion is in either the patch or the cover letter so it's a bit unclear, some confirmation would be good :( --tmoQ0UElFV5VgXgH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWJRWJAAoJECTWi3JdVIfQDnkH/21yDAfjjam01THCt1nwF38r dtojzNsMzERp8iWqE6hXTB0w2bunlH1JRvXgpQjoSe+ZugH/82OoL+rF0AlQbsWf uO0JUsWEUgicgr+y1bnRy97h0gbIY402nr1c/VvyoVK+ITV9FLrgrfKrkFWXJH8n jvOLz+vOYtWQWq1jKK0b0E4gdJ5TrQwYxDyFVZL9MMvQMl3c5eeoduGB5ssjxTdj 15j0ku8/Q0TqQTYPRul37wrSaOD62iRCbKxzkEGH6hzlTcJRPEPLBj35fEuRIbLA SkXmQcaotdEcwMj5u0OMq+/gPKVe9Vqx8VQ62uF6rKLOJCkML5fzytb+GGRlpJ4= =WgRq -----END PGP SIGNATURE----- --tmoQ0UElFV5VgXgH--