mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.org, jmorris@namei.org
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	dhowells@redhat.com, linux-security-module@vger.kernel.org,
	keyrings@vger.kernel.org, dvyukov@google.com
Subject: [PATCH 0/2] KEYS: Fix crash in GC
Date: Mon, 19 Oct 2015 17:12:48 +0100	[thread overview]
Message-ID: <20151019161248.3215.91824.stgit@warthog.procyon.org.uk> (raw)


Hi James, Linus,

Here are two patches, the first of which at least should go upstream
immediately:

 (1) Prevent a user-triggerable crash in the keyrings destructor when a
     negatively instantiated keyring is garbage collected.  I have also seen
     this triggered for user type keys.

 (2) Prevent the user from using requesting that a keyring be created and
     instantiated through an upcall.  Doing so is probably safe since the
     keyring type ignores the arguments to its instantiation function - but we
     probably shouldn't let keyrings be created in this manner.

I'm okay with patch (2) being deferred to the next merge window if we're only
fixing security bugs at this time upstream.

The patches can be found here also:

	http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-fixes

David
---
David Howells (2):
      KEYS: Fix crash when attempt to garbage collect an uninstantiated keyring
      KEYS: Don't permit request_key() to construct a new keyring


 security/keys/gc.c          |    6 ++++--
 security/keys/request_key.c |    3 +++
 2 files changed, 7 insertions(+), 2 deletions(-)


             reply	other threads:[~2015-10-19 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 16:12 David Howells [this message]
2015-10-19 16:12 ` [PATCH 1/2] KEYS: Fix crash when attempt to garbage collect an uninstantiated keyring David Howells
2015-10-19 16:13 ` [PATCH 2/2] KEYS: Don't permit request_key() to construct a new keyring David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151019161248.3215.91824.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=dvyukov@google.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®