From: Dave Goodell <dgoodell@cisco.com>
To: Insu Yun <wuninsu@gmail.com>
Cc: umalhi@cisco.com, dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, taesoo@gatech.edu,
yeongjin.jang@gatech.edu, insu@gatech.edu
Subject: Re: [PATCH] usnix: correctly handle kzalloc return value
Date: Mon, 19 Oct 2015 11:24:32 -0500 [thread overview]
Message-ID: <20151019162431.GA42659@DGOODELL-M-F02A.cisco.com> (raw)
In-Reply-To: <1445108816-7616-1-git-send-email-wuninsu@gmail.com>
On Sat, Oct 17, 2015 at 07:06:56PM +0000, Insu Yun wrote:
> Since kzalloc returns memory address, not error code,
> it should be checked whether it is null or not.
>
> Signed-off-by: Insu Yun <wuninsu@gmail.com>
> ---
> drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
The subject says "usnix" where it should say "usnic". Otherwise:
Reviewed-by: Dave Goodell <dgoodell@cisco.com>
If you have more of these fixes for drivers/infiniband/hw/usnic/, you
can send them all through just Doug Ledford and linux-rdma@, no need to
copy all of linux-kernel@. You can also CC me instead of Upinder, whose
email bounces at this point, though I will see your patches sent to
linux-rdma@ even if I'm not explicitly CC-ed. The patch to update
MAINTAINERS for usnic has been submitted but hasn't yet percolated
somewhere you would have seen it:
https://patchwork.kernel.org/patch/7410421/
-Dave
next prev parent reply other threads:[~2015-10-19 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 19:06 Insu Yun
2015-10-19 16:24 ` Dave Goodell [this message]
2015-10-21 20:44 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019162431.GA42659@DGOODELL-M-F02A.cisco.com \
--to=dgoodell@cisco.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=insu@gatech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=taesoo@gatech.edu \
--cc=umalhi@cisco.com \
--cc=wuninsu@gmail.com \
--cc=yeongjin.jang@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®