From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754652AbbJSSZO (ORCPT ); Mon, 19 Oct 2015 14:25:14 -0400 Received: from skprod2.natinst.com ([130.164.80.23]:33657 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754500AbbJSSZL (ORCPT ); Mon, 19 Oct 2015 14:25:11 -0400 Date: Mon, 19 Oct 2015 13:24:16 -0500 From: Josh Cartwright To: Michal Simek Cc: Moritz Fischer , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, soren.brinkmann@xilinx.com, linux@arm.linux.org.uk, atull@opensource.altera.com, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform. Message-ID: <20151019182416.GL12756@jcartwri.amer.corp.natinst.com> References: <1445035350-3569-1-git-send-email-moritz.fischer@ettus.com> <1445035350-3569-3-git-send-email-moritz.fischer@ettus.com> <20151018175324.GH12756@jcartwri.amer.corp.natinst.com> <5624F985.8050905@xilinx.com> MIME-Version: 1.0 In-Reply-To: <5624F985.8050905@xilinx.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 10/19/2015 01:24:16 PM, Serialize by Router on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 10/19/2015 01:24:16 PM, Serialize complete at 10/19/2015 01:24:16 PM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-19_15:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 19, 2015 at 04:09:09PM +0200, Michal Simek wrote: > On 10/18/2015 07:53 PM, Josh Cartwright wrote: > > On Fri, Oct 16, 2015 at 03:42:29PM -0700, Moritz Fischer wrote: [..] > >> @@ -294,6 +294,11 @@ > >> devcfg: devcfg@f8007000 { > >> compatible = "xlnx,zynq-devcfg-1.0"; > >> reg = <0xf8007000 0x100>; > >> + interrupt-parent = <&intc>; > > > > You shouldn't need interrupt-parent here. In fact, I suspect it can be > > removed from all sibling nodes as well. > > Correct. But I tend to do it vice-versa. To remove it from amba node and > keep it in every IP here. The reason is simple to let everybody know > that setting up right interrupt controller is something what they have > to care. If you have more interrupt controllers in the system it can be > messy. If you like that, then you'd like the interrupt-extended properly even better (I think). > But again. Please remove this patch from this series. This will go to > mainline through arm-soc but 1/3 and 3/3 will go through Greg. That's > why please do not include it here. Not all of the patches in a series need to go through the same maintainer...splitting them up is common. It's nice seeing related things out on the list together. (Especially when there is a dependency at some level). Josh