From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753545AbbJSS2X (ORCPT ); Mon, 19 Oct 2015 14:28:23 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37633 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753587AbbJSS2V (ORCPT ); Mon, 19 Oct 2015 14:28:21 -0400 Date: Mon, 19 Oct 2015 19:27:58 +0100 From: Mark Brown To: Damien Horsley Cc: alsa-devel@alsa-project.org, James Hartley , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20151019182758.GK32054@sirena.org.uk> References: <1444653637-14711-1-git-send-email-Damien.Horsley@imgtec.com> <1444653637-14711-9-git-send-email-Damien.Horsley@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k18oBAwMkTg3OUap" Content-Disposition: inline In-Reply-To: <1444653637-14711-9-git-send-email-Damien.Horsley@imgtec.com> X-Cookie: HUGH BEAUMONT died in 1982!! User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel] [PATCH V2 08/10] ASoC: img: Add driver for SPDIF input controller X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --k18oBAwMkTg3OUap Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 12, 2015 at 01:40:35PM +0100, Damien Horsley wrote: > +static int img_spdif_in_get_lock_acquire(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + struct snd_soc_dai *cpu_dai = snd_kcontrol_chip(kcontrol); > + struct img_spdif_in *spdif = snd_soc_dai_get_drvdata(cpu_dai); > + > + ucontrol->value.integer.value[0] = spdif->lock_acquire; > + > + return 0; > +} It would be nice to get some documentation of what these controls are... --k18oBAwMkTg3OUap Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWJTYuAAoJECTWi3JdVIfQUSsH/0OyVUdjnBm+bHJDFM447k+U 3ObSZ6IIGW+Wjq4t7p+cJqmtC2E0aHz+8Knfjo4G7ItoHIYbUObkehmml7UJuZR0 843C2jjwob5oaaKsXjNZi3EIya1frsin31OLt9OK+PBZHldot2nHKqFGExO5oiMf dVqgdlsOjGGUL8h/DOD7SkeJnXhi2HbJWqSWFOImiBRlyE4P8+G7Qof9+nrPKPcu hkTngSWg1Ho6IwnhYm9N1a6NCZHyTkm0RzMb73qk7/cxwPKGF0uiIdOfBpyNr2uA syJZ7NjhWgMjVFWS1XPpa4ggjz23p9KNf87jbzQFbHpoTCi0eVmRi5nBqmRqpUk= =wqHD -----END PGP SIGNATURE----- --k18oBAwMkTg3OUap--