From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752691AbbJTMxP (ORCPT ); Tue, 20 Oct 2015 08:53:15 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:50500 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144AbbJTMxM (ORCPT ); Tue, 20 Oct 2015 08:53:12 -0400 Date: Tue, 20 Oct 2015 13:52:52 +0100 From: Russell King - ARM Linux To: Michael Turquette Cc: Geert Uytterhoeven , Kevin Hilman , Tony Lindgren , Sekhar Nori , Sascha Hauer , Linux-sh list , Stephen Boyd , "linux-kernel@vger.kernel.org" , Santosh Shilimkar , Linux PM list , Maxime Ripard , "linux-omap@vger.kernel.org" , Lee Jones , linux-clk , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH RFC RFT 2/3] clk: clk_put WARNs if user has not disabled clk Message-ID: <20151020125251.GM32536@n2100.arm.linux.org.uk> References: <1438974570-20812-1-git-send-email-mturquette@baylibre.com> <1438974570-20812-3-git-send-email-mturquette@baylibre.com> <20151020124000.20687.60752@quantum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151020124000.20687.60752@quantum> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2015 at 05:40:00AM -0700, Michael Turquette wrote: > Why not keep the reference to the struct clk after get'ing it the first > time? Yes, that's exactly what you're supposed to do in this case. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.