From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>,
Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
Tawfik Bayouk <tawfik@marvell.com>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-kernel@vger.kernel.org, Nadav Haklai <nadavh@marvell.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal
Date: Tue, 20 Oct 2015 15:17:36 +0100 [thread overview]
Message-ID: <20151020141736.GX32532@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20151020160828.497fcc80@free-electrons.com>
On Tue, Oct 20, 2015 at 04:08:28PM +0200, Thomas Petazzoni wrote:
> As discussed on IRC, another simpler (code line wise) solution is to
> simply clear the IRQ_NOAUTOEN flag in the irq-armada-370-xp, which
> brings us back to what set_irq_flags() was doing, without actually
> reverting Rob's patch.
>
> However, relying on IRQ_NOAUTOEN being cleared doesn't seem like the
> right long term solution, which is why I implemented what I believe is
> a (hopefully) better long term solution.
However, this is rather worrying. NOAUTOEN is supposed to avoid enabling
the interrupt when the interrupt is claimed.
If, as a result of Rob's patch, we now have a load of IRQs which are
marked with NOAUTOEN which weren't, that's quite a large regression -
possibly one which hasn't been properly found (not everyone tests -rc
kernels) and we may be better to revert Rob's patch to avoid lots of
breakge being reported when 4.3 is released.
I think Rob's patches need another review in light of this, to determine
how much breakage there is here, and a decision how to proceed made on
that basis.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-10-20 14:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 13:23 Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 1/5] kernel: irq: implement is_enabled_percpu_irq() Thomas Petazzoni
2015-12-08 11:57 ` [tip:irq/core] genirq: Implement irq_percpu_is_enabled() tip-bot for Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 2/5] irqchip: armada-370-xp: prepare additions to armada_xp_mpic_secondary_init() Thomas Petazzoni
2015-10-20 14:00 ` Gregory CLEMENT
2015-10-20 13:23 ` [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts at resume time Thomas Petazzoni
2015-10-20 13:46 ` Gregory CLEMENT
2015-10-20 13:50 ` Thomas Petazzoni
2015-10-25 21:22 ` Marcin Wojtas
2015-10-26 0:10 ` Thomas Petazzoni
2015-10-26 4:35 ` Marcin Wojtas
2015-10-26 5:09 ` Thomas Petazzoni
2015-10-26 7:06 ` Marcin Wojtas
2015-10-26 8:27 ` Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 4/5] irqchip: armada-370-xp: re-order register definitions Thomas Petazzoni
2015-10-20 13:55 ` Gregory CLEMENT
2015-10-20 13:23 ` [PATCH 5/5] irqchip: armada-370-xp: document the overall driver logic Thomas Petazzoni
2015-10-20 13:59 ` Gregory CLEMENT
2015-10-20 14:00 ` Thomas Petazzoni
2015-10-20 14:07 ` Jason Cooper
2015-10-20 14:04 ` [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Jason Cooper
2015-10-20 14:08 ` Thomas Petazzoni
2015-10-20 14:17 ` Russell King - ARM Linux [this message]
2015-10-20 14:23 ` Thomas Petazzoni
2015-10-20 19:24 ` Thomas Gleixner
2015-10-22 8:01 ` Thomas Gleixner
2015-10-20 19:23 ` Thomas Gleixner
2015-10-21 13:48 ` [PATCH] irqchip: irq-armada-370-xp: fix regression by clearing IRQ_NOAUTOEN Thomas Petazzoni
2015-10-21 14:41 ` Jason Cooper
2015-10-21 13:49 ` [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Thomas Petazzoni
2015-11-11 8:26 ` Thomas Petazzoni
2015-11-13 20:11 ` Thomas Gleixner
2015-12-04 11:03 ` Thomas Petazzoni
2015-12-05 17:24 ` Thomas Gleixner
2015-12-06 9:28 ` Thomas Gleixner
2015-12-08 8:58 ` Thomas Petazzoni
2015-12-08 10:54 ` Thomas Gleixner
2017-02-24 16:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020141736.GX32532@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®