From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752022AbbJTTjS (ORCPT ); Tue, 20 Oct 2015 15:39:18 -0400 Received: from smtprelay0211.hostedemail.com ([216.40.44.211]:51068 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750796AbbJTTjN (ORCPT ); Tue, 20 Oct 2015 15:39:13 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1434:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2897:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:4321:4605:5007:6119:6120:6261:7875:7901:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:13972:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: hands46_8a5bc7636f65c X-Filterd-Recvd-Size: 2874 Date: Tue, 20 Oct 2015 15:39:09 -0400 From: Steven Rostedt To: Andi Kleen Cc: x86@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 3/4] x86: Add trace point for MSR accesses Message-ID: <20151020153909.04942f11@gandalf.local.home> In-Reply-To: <1445366446-17668-4-git-send-email-andi@firstfloor.org> References: <1445366446-17668-1-git-send-email-andi@firstfloor.org> <1445366446-17668-4-git-send-email-andi@firstfloor.org> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Oct 2015 11:40:45 -0700 Andi Kleen wrote: > diff --git a/include/trace/events/msr.h b/include/trace/events/msr.h Architecture specific tracepoints should not exist in include/trace. Please move this to arch/x86/lib (or some other x86 directory). See samples/trace_events/ for how to have a header outside of include/trace. -- Steve > new file mode 100644 > index 0000000..b2232b5 > --- /dev/null > +++ b/include/trace/events/msr.h > @@ -0,0 +1,51 @@ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM msr > + > +#if !defined(_TRACE_MSR_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_MSR_H > + > +#include > + > +/* > + * Tracing for x86 model specific registers. Directly maps to the > + * RDMSR/WRMSR instructions. > + */ > + > +DECLARE_EVENT_CLASS(msr_trace_class, > + TP_PROTO(unsigned msr, u64 val, int failed), > + TP_ARGS(msr, val, failed), > + TP_STRUCT__entry( > + __field( unsigned, msr ) > + __field( u64, val ) > + __field( int, failed ) > + ), > + TP_fast_assign( > + __entry->msr = msr; > + __entry->val = val; > + __entry->failed = failed; > + ), > + TP_printk("%x, value %llx%s", > + __entry->msr, > + __entry->val, > + __entry->failed ? " #GP" : "") > +); > + > +DEFINE_EVENT(msr_trace_class, read_msr, > + TP_PROTO(unsigned msr, u64 val, int failed), > + TP_ARGS(msr, val, failed) > +); > + > +DEFINE_EVENT(msr_trace_class, write_msr, > + TP_PROTO(unsigned msr, u64 val, int failed), > + TP_ARGS(msr, val, failed) > +); > + > +DEFINE_EVENT(msr_trace_class, rdpmc, > + TP_PROTO(unsigned msr, u64 val, int failed), > + TP_ARGS(msr, val, failed) > +); > + > +#endif /* _TRACE_MSR_H */ > + > +/* This part must be outside protection */ > +#include