From: Yunhong Jiang <yunhong.jiang@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, viresh.kumar@linaro.org
Subject: Re: [PATCH] timer: Lazily wakup nohz CPU when adding new timer.
Date: Tue, 20 Oct 2015 15:47:51 -0700 [thread overview]
Message-ID: <20151020224751.GB31289@jnakajim-build> (raw)
In-Reply-To: <alpine.DEB.2.11.1510112010250.6097@nanos>
On Sun, Oct 11, 2015 at 08:12:39PM +0200, Thomas Gleixner wrote:
> On Mon, 28 Sep 2015, Yunhong Jiang wrote:
> > static void internal_add_timer(struct tvec_base *base, struct timer_list *timer)
> > {
> > + bool kick_nohz = false;
> > +
> > /* Advance base->jiffies, if the base is empty */
> > if (!base->all_timers++)
> > base->timer_jiffies = jiffies;
> > @@ -424,9 +426,17 @@ static void internal_add_timer(struct tvec_base *base, struct timer_list *timer)
> > */
> > if (!(timer->flags & TIMER_DEFERRABLE)) {
> > if (!base->active_timers++ ||
> > - time_before(timer->expires, base->next_timer))
> > + time_before(timer->expires, base->next_timer)) {
> > base->next_timer = timer->expires;
> > - }
> > + /*
> > + * CPU in dynticks need reevaluate the timer wheel
> > + * if newer timer added with next_timer updated.
> > + */
> > + if (base->nohz_active)
> > + kick_nohz = true;
> > + }
> > + } else if (base->nohz_active && tick_nohz_full_cpu(base->cpu))
> > + kick_nohz = true;
>
> Why do you want to kick the other cpu when a deferrable timer got added?
This is what happens in current implementation and this patch does not
change the logic. According to the comments, it's to avoid race with
idle_cpu(). Frankly speaking, I didn't get the idea of the race.
Viresh, do you have any hints?
Thanks
--jyh
>
> Thanks,
>
> tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-10-20 22:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 18:48 Yunhong Jiang
2015-10-05 20:51 ` Yunhong Jiang
2015-10-11 18:12 ` Thomas Gleixner
2015-10-20 22:47 ` Yunhong Jiang [this message]
2015-10-21 10:46 ` Viresh Kumar
2015-10-22 21:40 ` Yunhong Jiang
2015-10-23 2:19 ` Viresh Kumar
2015-10-23 22:10 ` Yunhong Jiang
2015-10-24 3:20 ` Viresh Kumar
2015-10-26 16:26 ` Yunhong Jiang
2015-10-27 15:11 ` Frederic Weisbecker
2015-11-13 16:13 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020224751.GB31289@jnakajim-build \
--to=yunhong.jiang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®