From: Dave Martin <Dave.Martin@arm.com>
To: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com,
Vladimir.Murzin@arm.com, steve.capper@linaro.org,
ryan.arnold@linaro.org, ard.biesheuvel@linaro.org,
aph@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, edward.nevill@linaro.org,
james.morse@arm.com, andre.przywara@arm.com,
marc.zyngier@arm.com, christoffer.dall@linaro.org
Subject: Re: [UPDATED] [PATCHv4 00/24] arm64: Consolidate CPU feature handling
Date: Wed, 21 Oct 2015 11:28:06 +0100 [thread overview]
Message-ID: <20151021102806.GH4801@e103592.cambridge.arm.com> (raw)
In-Reply-To: <1445261101-22344-1-git-send-email-suzuki.poulose@arm.com>
On Mon, Oct 19, 2015 at 02:24:37PM +0100, Suzuki K. Poulose wrote:
> Resending the series with fixed mail ids.
>
> ---
> This series introduces a new infrastructure to keep track of the CPU
> feature registers on ARMv8-A for arm64 kernel. It provides the safe value
> of a CPU feature register across all the CPUs on (a heterogeneous) system.
> The infrastructure checks the individual CPU feature registers as they are
> brought online (during system boot up) and udpates the status of each of
> the feature bits across the system. Once all the active CPUs are brought
> online (i.e, smp_cpus_done() ), the system can compute a reliable set of
> capabilities (arm64_features CPU capability and ELF HWCAP). This allows
> system to operate safely on CPUs with differing capabilities. Any new CPU
> brought up(hotplugged in) should have all the established capabilities,
> failing which could be disastrous. (e.g, alternative code patched in for
> a feature avaialble on the system). We add a hotplug notifier to check if
> the new CPU is missing any of the advertised capabilities and prevents it
> from turning online if it is.
[...]
For the series,
Tested-by: Dave Martin <Dave.Martin@arm.com>
(i.e., the system boots and MRS from userspace seems to do the correct
thing -- I haven't stressed the series.)
I don't propose to review the patch content in detail since other
people have already looked at it, the the code looks reasonable and
seems to work but I'll let you know if I spot anything.
Cheers
---Dave
prev parent reply other threads:[~2015-10-21 10:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 13:24 Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 01/24] arm64: Make the CPU information more clear Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 02/24] arm64: Delay ELF HWCAP initialisation until all CPUs are up Suzuki K. Poulose
2015-10-21 8:44 ` Dave Martin
2015-10-21 9:18 ` Catalin Marinas
2015-10-19 13:24 ` [PATCHv4 03/24] arm64: Delay cpuinfo_store_boot_cpu Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 04/24] arm64: Move cpu feature detection code Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 05/24] arm64: Move mixed endian support detection Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 06/24] arm64: Move /proc/cpuinfo handling code Suzuki K. Poulose
2015-10-21 9:00 ` Dave Martin
2015-10-21 9:21 ` Catalin Marinas
2015-10-19 13:24 ` [PATCHv4 07/24] arm64: Handle width of a cpuid feature Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 08/24] arm64: Keep track of CPU feature registers Suzuki K. Poulose
2015-10-21 8:48 ` Dave Martin
2015-10-19 13:24 ` [PATCHv4 09/24] arm64: Consolidate CPU Sanity check to CPU Feature infrastructure Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 10/24] arm64: Read system wide CPUID value Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 11/24] arm64: Cleanup mixed endian support detection Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 12/24] arm64: Refactor check_cpu_capabilities Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 13/24] arm64: Delay cpu feature capability checks Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 14/24] arm64/capabilities: Make use of system wide safe value Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 15/24] arm64/HWCAP: Use system wide safe values Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 16/24] arm64: Move FP/ASIMD hwcap handling to common code Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 17/24] arm64/debug: Make use of the system wide safe value Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 18/24] arm64/kvm: Make use of the system wide safe values Suzuki K. Poulose
2015-10-19 13:39 ` Christoffer Dall
2015-10-19 15:26 ` Catalin Marinas
2015-10-19 13:24 ` [PATCHv4 19/24] arm64: Documentation - Expose CPU feature registers Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 20/24] arm64: Define helper for sys_reg id manipulation Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 21/24] arm64: Add helper to decode register from instruction Suzuki K. Poulose
2015-10-19 13:24 ` [PATCHv4 22/24] arm64: cpufeature: Track the user visible fields Suzuki K. Poulose
2015-10-19 13:25 ` [PATCHv4 23/24] arm64: Expose feature registers by emulating MRS Suzuki K. Poulose
2015-10-21 8:50 ` Dave Martin
2015-10-19 13:25 ` [PATCHv4 24/24] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to sysfs Suzuki K. Poulose
2015-10-21 9:28 ` [UPDATED] [PATCHv4 00/24] arm64: Consolidate CPU feature handling Catalin Marinas
2015-10-21 10:28 ` Dave Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021102806.GH4801@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=Vladimir.Murzin@arm.com \
--cc=andre.przywara@arm.com \
--cc=aph@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=edward.nevill@linaro.org \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=ryan.arnold@linaro.org \
--cc=steve.capper@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®