From: Mark Brown <broonie@kernel.org>
To: Heiko Schocher <hs@denx.de>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] regulator, dt: add dt support for tps6502x regulator
Date: Wed, 21 Oct 2015 13:19:25 +0100 [thread overview]
Message-ID: <20151021121925.GC8232@sirena.org.uk> (raw)
In-Reply-To: <1445236033-27747-1-git-send-email-hs@denx.de>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Mon, Oct 19, 2015 at 08:27:13AM +0200, Heiko Schocher wrote:
> --- /dev/null
> +++ b/arch/arm/boot/dts/tps65023.dtsi
If this file is needed there is something broken, if this file is not
needed then it is just noise since everything in it needs to be
overridden by users anyway. Either way please remove it.
> + vldo2_reg: regulator@4 {
> + reg = <4>;
> + regulator-compatible = "vldo2", "regulator-compatible";
Modern bindings no longer use regulator-compatible, they just use the
node name - please look at recently added bindings for examples.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-21 12:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 7:14 kbuild test robot
2015-10-19 6:27 ` Heiko Schocher
2015-10-19 7:14 ` [RFC PATCH] regulator, dt: tps6502x_parse_dt_data() can be static kbuild test robot
2015-10-21 12:19 ` Mark Brown [this message]
2015-10-21 12:52 ` [PATCH] regulator, dt: add dt support for tps6502x regulator Heiko Schocher
2015-10-21 16:17 ` Mark Brown
2015-10-22 4:51 ` Heiko Schocher
2015-10-22 12:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021121925.GC8232@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hs@denx.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome