From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756159AbbJUT5Y (ORCPT <rfc822;w@1wt.eu>);
	Wed, 21 Oct 2015 15:57:24 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:18074 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754726AbbJUT5W (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 21 Oct 2015 15:57:22 -0400
Date: Wed, 21 Oct 2015 15:56:40 -0400
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andre Przywara <andre.przywara@arm.com>, Joerg Roedel <joro@8bytes.org>,
        "David S. Miller" <davem@davemloft.net>,
        sparclinux <sparclinux@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Parisc List <linux-parisc@vger.kernel.org>,
        iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu-common: fix return type of iommu_tbl_range_alloc()
Message-ID: <20151021195640.GC14667@oracle.com>
References: <55FBD36C.5070301@arm.com>
 <1442567375-6963-1-git-send-email-andre.przywara@arm.com>
 <CAMuHMdXGM0ynDSv-_MdZptXeqJ=sU7=LChmihSCoqanVTUpWXQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMuHMdXGM0ynDSv-_MdZptXeqJ=sU7=LChmihSCoqanVTUpWXQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (10/21/15 21:12), Geert Uytterhoeven wrote:
> 
> Does this function really need to return DMA_ERROR_CODE in case of
> failure?

fwiw, this came up very early in code review:

  http://marc.info/?l=linux-sparc&m=142613044704833&w=2

--Sowmini