From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757698AbbJVOFP (ORCPT ); Thu, 22 Oct 2015 10:05:15 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54330 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755864AbbJVOFN (ORCPT ); Thu, 22 Oct 2015 10:05:13 -0400 Date: Thu, 22 Oct 2015 07:21:39 -0700 (PDT) Message-Id: <20151022.072139.454804647788377055.davem@davemloft.net> To: jhansen@vmware.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, gregkh@linuxfoundation.org, pv-drivers@vmware.com Subject: Re: [PATCH] VSOCK: sock_put wasn't safe to call in interrupt context From: David Miller In-Reply-To: <1445428436-52369-1-git-send-email-jhansen@vmware.com> References: <1445428436-52369-1-git-send-email-jhansen@vmware.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 22 Oct 2015 07:05:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jorgen Hansen Date: Wed, 21 Oct 2015 04:53:56 -0700 > In the vsock vmci_transport driver, sock_put wasn't safe to call > in interrupt context, since that may call the vsock destructor > which in turn calls several functions that should only be called > from process context. This change defers the callling of these > functions to a worker thread. All these functions were > deallocation of resources related to the transport itself. > > Furthermore, an unused callback was removed to simplify the > cleanup. > > Multiple customers have been hitting this issue when using > VMware tools on vSphere 2015. > > Also added a version to the vmci transport module (starting from > 1.0.2.0-k since up until now it appears that this module was > sharing version with vsock that is currently at 1.0.1.0-k). > > Reviewed-by: Aditya Asarwade > Reviewed-by: Thomas Hellstrom > Signed-off-by: Jorgen Hansen Applied, thanks.