From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964874AbbJVJIE (ORCPT ); Thu, 22 Oct 2015 05:08:04 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:38406 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbbJVJH7 (ORCPT ); Thu, 22 Oct 2015 05:07:59 -0400 Date: Thu, 22 Oct 2015 11:07:56 +0200 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: Re: [PATCH] mm: memcontrol: eliminate root memory.current Message-ID: <20151022090756.GB26854@dhcp22.suse.cz> References: <1445453394-15156-1-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445453394-15156-1-git-send-email-hannes@cmpxchg.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 21-10-15 14:49:54, Johannes Weiner wrote: > memory.current on the root level doesn't add anything that wouldn't be > more accurate and detailed using system statistics. It already doesn't > include slabs, and it'll be a pain to keep in sync when further memory > types are accounted in the memory controller. Remove it. > > Note that this applies to the new unified hierarchy interface only. OK, I can understand your reasoning, other knobs are !root as well. > Signed-off-by: Johannes Weiner After the bug mentioned below is fixed Acked-by: Michal Hocko > --- > mm/memcontrol.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Tejun, we should probably do this with the other controllers too. > I don't think it makes sense anywhere to shoddily duplicate the > system statistics on the controller root levels. > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 4f04510..c71fe40 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5022,7 +5022,7 @@ static void mem_cgroup_bind(struct cgroup_subsys_state *root_css) > static u64 memory_current_read(struct cgroup_subsys_state *css, > struct cftype *cft) > { > - return mem_cgroup_usage(mem_cgroup_from_css(css), false); > + return page_counter_read(&mem_cgroup_from_css(css)->memory); We want that in bytes though. > } > > static int memory_low_show(struct seq_file *m, void *v) > @@ -5134,6 +5134,7 @@ static int memory_events_show(struct seq_file *m, void *v) > static struct cftype memory_files[] = { > { > .name = "current", > + .flags = CFTYPE_NOT_ON_ROOT, > .read_u64 = memory_current_read, > }, > { > -- > 2.6.1 -- Michal Hocko SUSE Labs