From: Ingo Molnar <mingo@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/3] x86, perf: Use a new PMU ack sequence
Date: Thu, 22 Oct 2015 11:25:08 +0200 [thread overview]
Message-ID: <20151022092508.GA21192@gmail.com> (raw)
In-Reply-To: <20151021214638.GH15102@tassilo.jf.intel.com>
* Andi Kleen <ak@linux.intel.com> wrote:
> > > v2:
> > > Use new ack sequence unconditionally. Remove pmu reset code.
> >
> > So this is not something we can easily revert if things go bad. Esp.
> > since you build on it with the next patches.
>
> Ok, and?
Sigh, you are being disruptive again.
> You want me to go back to the previous patch? That one is easily
> undoable (just disable the flag for the model)
>
> Another alternative would be to fork the PMI handler into a new and
> an old version, that is switchable.
Here you pretend that you didn't read the sane solution that was suggested to you
just three days ago:
http://lkml.kernel.org/r/20151019070812.GB17855@gmail.com
" > > Ingo, do you want to first merge the safe patch and then clean up?
>
> Yeah, would be nice to structure it that way, out of general paranoia.
"
I.e. first apply the safe approach, then, after the dependent changes, clean it up
by introducing the dangerous change.
The thing is, I'm close to summarily NAK-ing any patches from you to the perf
subsystem, due to the unacceptably low quality patches combined with obtuse
passive-aggressive obstruction you are routinely burdening maintainers with.
Btw., I noticed that you routinely don't Cc me to perf patches. Please always Cc:
me to perf patches (both kernel and tooling patches). I still will not apply them
directly, only if another perf maintainer signs off on them, but I'd like to have
a record of all your submissions.
Thanks,
Ingo
prev parent reply other threads:[~2015-10-22 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 20:16 Andi Kleen
2015-10-21 20:16 ` [PATCH 2/3] x86, perf: Factor out BTS enable/disable functions Andi Kleen
2015-10-21 20:16 ` [PATCH 3/3] perf, x86: Use counter freezing with Arch Perfmon v4 Andi Kleen
2015-10-21 20:36 ` [PATCH 1/3] x86, perf: Use a new PMU ack sequence Peter Zijlstra
2015-10-21 21:46 ` Andi Kleen
2015-10-22 9:25 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022092508.GA21192@gmail.com \
--to=mingo@kernel.org \
--cc=acme@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome