From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757241AbbJVK65 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 22 Oct 2015 06:58:57 -0400
Received: from pandora.arm.linux.org.uk ([78.32.30.218]:55704 "EHLO
	pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754669AbbJVK6z (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 22 Oct 2015 06:58:55 -0400
Date: Thu, 22 Oct 2015 11:58:41 +0100
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Franklin S Cooper Jr <fcooper@ti.com>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Muralidharan Karicheri <m-karicheri2@ti.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2
Message-ID: <20151022105841.GR32532@n2100.arm.linux.org.uk>
References: <1445377809-12516-1-git-send-email-fcooper@ti.com>
 <1445377809-12516-2-git-send-email-fcooper@ti.com>
 <CAPDyKFr6qt60gECs5y=Qq6XbFhiqWGrOcMozB4vNwaR8PHnu4A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPDyKFr6qt60gECs5y=Qq6XbFhiqWGrOcMozB4vNwaR8PHnu4A@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 22, 2015 at 11:28:55AM +0200, Ulf Hansson wrote:
> On 20 October 2015 at 23:50, Franklin S Cooper Jr <fcooper@ti.com> wrote:
> >
> > From: Lokesh Vutla <lokeshvutla@ti.com>
> >
> > Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
> > IP found on OMAP platforms.
> >
> > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> > ---
> >  drivers/mmc/host/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 8a1e349..2ccec71 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -366,7 +366,7 @@ config MMC_OMAP
> >  config MMC_OMAP_HS
> >         tristate "TI OMAP High Speed Multimedia Card Interface support"
> >         depends on HAS_DMA
> > -       depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > +       depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
> 
> How about:
> "depends on ARM || COMPILE_TEST"

I'd much prefer the former actually - it's already hard enough to use
the config tools with the kernel due to the number of silly options
being presented, there's no need to make it worse.

In fact, I'd like to see more of the former (provided done sensibly)
to reduce the number of config options seen for configurations to cut
down on the shere noise of useless options.  For example, if I've
decided I don't want to support TI OMAP platforms, then I shouldn't
be offered the TI OMAP MMC driver.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.