From: Peter Zijlstra <peterz@infradead.org>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@kernel.org>, Wang Nan <wangnan0@huawei.com>,
He Kuang <hekuang@huawei.com>, Kaixu Xia <xiakaixu@huawei.com>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper
Date: Thu, 22 Oct 2015 15:57:45 +0200 [thread overview]
Message-ID: <20151022135745.GM3604@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1445468283-4592-1-git-send-email-ast@kernel.org>
On Wed, Oct 21, 2015 at 03:58:03PM -0700, Alexei Starovoitov wrote:
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 64754bfecd70..0b6333265872 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -3258,7 +3258,7 @@ static inline u64 perf_event_count(struct perf_event *event)
> u64 perf_event_read_local(struct perf_event *event)
> {
> unsigned long flags;
> - u64 val;
> + u64 val = -EINVAL;
No, you cannot do this, -EINVAL is a valid count value. You simply must
not call this function on !local events, ever.
next prev parent reply other threads:[~2015-10-22 13:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 22:58 Alexei Starovoitov
2015-10-22 4:49 ` Wangnan (F)
2015-10-22 5:00 ` Alexei Starovoitov
2015-10-22 5:30 ` Wangnan (F)
2015-10-22 5:31 ` Wangnan (F)
2015-10-22 6:21 ` Alexei Starovoitov
2015-10-22 7:39 ` Wangnan (F)
2015-10-22 15:51 ` Alexei Starovoitov
2015-10-22 12:30 ` Wangnan (F)
2015-10-22 12:41 ` Peter Zijlstra
2015-10-22 13:57 ` Peter Zijlstra [this message]
2015-10-22 15:53 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022135745.GM3604@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangnan0@huawei.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome