From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965259AbbJVPO1 (ORCPT ); Thu, 22 Oct 2015 11:14:27 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34800 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965091AbbJVPOW (ORCPT ); Thu, 22 Oct 2015 11:14:22 -0400 Date: Fri, 23 Oct 2015 00:14:14 +0900 From: Tejun Heo To: Christoph Lameter Cc: Tetsuo Handa , mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, David Rientjes , oleg@redhat.com, kwalker@redhat.com, akpm@linux-foundation.org, hannes@cmpxchg.org, vdavydov@parallels.com, skozina@redhat.com, mgorman@suse.de, riel@redhat.com Subject: Re: [PATCH] mm,vmscan: Use accurate values for zone_reclaimable() checks Message-ID: <20151022151414.GF30579@mtj.duckdns.org> References: <201510222037.ACH86458.OFOLFtQFOHJSVM@I-love.SAKURA.ne.jp> <20151022140944.GA30579@mtj.duckdns.org> <20151022142155.GB30579@mtj.duckdns.org> <20151022142429.GC30579@mtj.duckdns.org> <20151022143349.GD30579@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Oct 22, 2015 at 09:41:11AM -0500, Christoph Lameter wrote: > > If this is actually a legit busy-waiting cyclic dependency, just let > > me know. > > There is no dependency of the vmstat updater on anything. > They can run anytime. If there is a dependency then its created by the > kworker subsystem itself. Sure, the other direction is from workqueue concurrency detection. I was asking whether a work item can busy-wait on vmstat_update work item cuz that's what confuses workqueue. Looking at the original dump, the pool has two idle workers indicating that the workqueue wasn't short of execution resources and it really looks like that work item was live-locking the pool. I'll go ahead and add WQ_IMMEDIATE. Thanks. -- tejun