From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753681AbbJVQd1 (ORCPT ); Thu, 22 Oct 2015 12:33:27 -0400 Received: from mail-by2on0066.outbound.protection.outlook.com ([207.46.100.66]:35008 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750814AbbJVQdY (ORCPT ); Thu, 22 Oct 2015 12:33:24 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; grandegger.com; dkim=none (message not signed) header.d=none;grandegger.com; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Thu, 22 Oct 2015 09:33:15 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Kedareswara rao Appana CC: , , , , , , , , Subject: Re: [PATCH 2/2] can: xilinx: fix bug in bus error handling Message-ID: <20151022163315.GI5257@xsjsorenbubuntu> References: <1445489163-11045-1-git-send-email-appanad@xilinx.com> <1445489163-11045-2-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1445489163-11045-2-git-send-email-appanad@xilinx.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21894.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD037;1:mMpyv5EP7Q6c2CGNsVEDFARqfFpX4axXGddf356BUPOdCc2mBf36sPSe8gOwUlbxKTc+wV6ZBKBfR11DDMiqC0mTVF0F8WHqJKaXDYvJlOBGIWLsxPh5/YhfVvLcl55GvHzUxEE9Mc8vzc7zaEauu9cZEj2DyxzvwTOlkFZKpjPifWlScXQ0UO/+4bXVF/KoHX5GTUxdEaaECVqsjGauYdntZ07MD5hqxwzzhAyVIWsHvqv1k2bPsIpZa851Cf3gfXpMeIbc/5OVTFnotS4k+D9SHE4vFSQtbBYtBpk4YVqWKM4ju2qr+IQXsjnsixDi2dkdPSHFB6Mjn3tOsTGi1hRe1SJ9AvVSej6M+eMoMWzQdVTOsrHiFSM6MiRvaDBMLcwP3WA/e7tX5KxlmlUeyg== X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(377424004)(189002)(199003)(33656002)(85182001)(87936001)(86362001)(4001350100001)(106466001)(36386004)(77096005)(81156007)(33716001)(50466002)(63266004)(76506005)(4001150100001)(57986006)(23676002)(85202003)(110136002)(50986999)(76176999)(54356999)(5007970100001)(46102003)(189998001)(19580395003)(83506001)(16796002)(19580405001)(4001450100002)(64706001)(5008740100001)(47776003)(11100500001)(5001960100002)(2950100001)(92566002)(6806005)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1AFFO11HUB012;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB012;2:2TzXF0c17q0xdz+qUM7pp5Il5DV8peQ49qkUwr4PyM+aC4yNmN7Zb9MBCRNigsYxcXuliXxqslsb/s4ntqJt5tmKkoJLgBf7fQG6StaXTwXnUvyQetmkeBTmNG2p2b5yxGq/0E72KbsVXtw7uCSSOEu1OdWow6/yVfKBAVHrYGs=;3:ei7geCUyXIkSbEQ9OdokpFfV11QJVXchxg6V2SOXni6aydRhC4H1ewcRCkbc1eDRNIrT48bRqXC2XJyaoXX95o8cwUrtR/mlH0GHVV3Px56gKhtfsPJcIqo3tuC5bcm3gqaXRxl98s4tirgwCujWgkqTX7KqlSEfqx6/fS6eY9J6lB8P+ag7A7cVyQ6EJ4BfWH4gq9Q/UOCP0qji1BrqyCpFOHhhQVhdmJV7JyHuaXt1xobYacsUoxql/fSOcQz0gEfKAUTyg6DPUWN3xnEH4g==;25:ak3FAHkuazBboVVlG4jJcaR+GC2LD3MBBI4bjbw020LHClWzi7KFdzu5B9nkhx8C8rFoJ82WEI6+jZbOFv+vjm2KquMmoiSEE76rklhg8TUvzACOt7+OIO6wM61lEmEEWzTJnZjvhvZxV39MXwZeRAu0bQHiE3ox0otQx8xd77nfUBSvwPz88Mk3xZ7IQ6XWYqJ7TndtPoL4Rbef41wVm4CPxr9IT97UA9DIolxMTYzZcRcD9ELBwZ/gFV89QqNVM9zhiGQFZNtT5NrpWFkGhw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN1AFFO11HUB012; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB012;20:P2C48gVylukcufJGC8rx7mqd5j2YeiPXbX2Qc/jNv7YB8KtenKIHBK79qeX9zkzfbajfiPAW8fW14DOVJPFNjL9QTJjb4fEJ1UNtJ8iWg5Hm6waE9nrlAZj7CW04bkXy83exzJwc7HQpYlbGfgYyW/CT+tr9kM1szfUri/zim9+VYiyfnXkI4BcSbdP0ocF5jDAkT4bBy6m+DU/TmuxpP2lwyuIQXbVq9tNgTpLbVRtq8I4AciwFsjnpCNZVox0vvRTO9Ha/2FzGo80p8yMmMTpWCmnC9oFnTSkBg54v82rS6l2o4DQ1eehuSoUXweopVA9Mwjpft/4e/jgciRtwhAQOo4422dQRlnz3Z1UgvCly7zvcdpi9F6igVudO5y0SZ8u+gqSi9bQoJblhV0ZSPGWZpDsHktBtWHXAed58/RjC559nDvAeS4P7sfTjiNTJVa2iuHKsgQwuaByZvJqXBYEn55ANqoJpMQlWHlZ+zksnKkLh1pgaFxNRljVZBTVu;4:3Q1+1jFzkdyqvKP6SCJ1TWANv/dWM2NwaXLibjzH1LTnvYvC4Dqcrg/E7JP0Ni2mxey7W471HT/F9JTSLUipPjbRwFIqHcxx9xl0LSJJjvHKkhm0rP78UrTHWhucNoBVZqwTAiAFq98nfm09l8KQnd40KbGJlqBmxjU27SrUhjHjuUOk1bvVa/cIKTOwqKh3+/DOsRpeAZDnxlXeALF1p8PKz0UmQ5vnwuGsKaK6aGv6kThdr6zVOQQVt1GDWCW2ugyhQw1PJpH4bKcNRLJApNlijbrHKy97bZvMnixq5qfribfS0lL9lG0bpE76w+ysml220E7B5Tfk5sLWXzov+4RlvEDbpxb/JhYvJrNk1b0Q0/DI7mDXwGRIBOvbcbst9shF4rFbT3qBW8MuO/dNQg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10115024)(102215026);SRVR:BN1AFFO11HUB012;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB012; X-Forefront-PRVS: 0737B96801 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFBRkZPMTFIVUIwMTI7MjM6T1RyOGh5dlA2Q2ZDUEM0b0dPMUp1SzA2?= =?utf-8?B?TkpjUUxtazA1dmxUd2hZMk55VHd6Uy9sK1BWdys2MWN5Z0N5U05zVmtUODFG?= =?utf-8?B?dGVUU2hWTEdaNjNNS0E4ZUt5OW91bEc5T202VFRidUxwelBFcysyQ3VleGdi?= =?utf-8?B?MkFCaGM1TG1KUVJhUHhaVWxsd2RYcmRlS1BjV1dldGJyWENRSVN0Sy9vb0N1?= =?utf-8?B?SWhyNVpJcnJKbGVYMUQzMHNab2VTdUZ1TmZza3huY2ZSV1BMSnEwd3h5OGRJ?= =?utf-8?B?WVR6VU55SVhWMkFya2h2MFh5VUxrU2g4aFZueEgxajdxL3M3RDgwVWx3R0pT?= =?utf-8?B?UFBOWjh2azNldmhHNUFVKzBMc2k4clVKNGlKQ0s0ZFVoRUdyWHF4N1hFOExr?= =?utf-8?B?L0RPVnc0Q0E0c2hyOHdCS3lzM3FsazV1YnI1cnIyQWhCbGJ5NlAvR25uUFNS?= =?utf-8?B?bmVBZ0hLUXIxbFd0WEM1UUZHcVJ4YTFLZU1wbUpra0t0dW8xVjFSY2lUTlcv?= =?utf-8?B?eit0eHUyaERZN056aHl0QkJELy9CR0dWbVAreXlyakVObzYxNGlyUW1tZWUr?= =?utf-8?B?SmJmVlU4dXU5Sk5WRk0vNDR2RC92ZkQ4S0FjTTBtMGNPc2I2MGJDcGd2bzQz?= =?utf-8?B?K09UdThhUmpQaWFoejdxOHVZLzVqNm5kOGgzMk1RSlY3TkRqSEhIa2IremNV?= =?utf-8?B?U1BkNHZzckxJVTEvMGZYNVpWSEhtVXNQSnlPaFZUS00rN0ZNQzNic09UWDhB?= =?utf-8?B?eGVYUkhvN2N5b3hrMHhHV0UxTW45WGM3dFBjekN0SVd0NlZIdTVoblRnYkUy?= =?utf-8?B?U3ZNRVFrck52QTg5MXpYQlhLZDUrRlRzdkRuZ0hWZXM0c2EraUVtR3c0emln?= =?utf-8?B?YnhVOFlIZ3ptcGVwZUZiQlhXSG5RenhCVjNQb3BXYitHblZDVUtCMHVOSDVa?= =?utf-8?B?THFBdEdBa2VyT0d2UkVOSnBaVy9lRXVrcFB6RDE3SE5zbDJpMWFkTFljK1pi?= =?utf-8?B?aEJ6VENsUjk3YjcvSDlGMHRyZnYwTWk5MFhmOVA2K1M1bllrekVMVVEyZDR2?= =?utf-8?B?SXRGNmZDUThJRWV2WDVzWS81N0V3ZmsvWWdrUmI5cU05MHY4ak9FWXQvN3A0?= =?utf-8?B?UVJXd0xEMWFTSmFVNlVVSmdYRTk5VGtEWlR2ZE8rWHhxWmt4aXRBT2UwS0R3?= =?utf-8?B?UXpzZUt4NWpqVFlWeFA2YzlPVFgwV21mZTgvUWpLdTJaNSt2MnRMTXRucU4w?= =?utf-8?B?QjhzSGlYNlArYmxCU3hqeXlyTWNZaWZ5aUNWa2ZCRzVTRFRDWG4zUkhuOStZ?= =?utf-8?B?bVdPT3ZCcVZ5T0tlbGFqZ2FiNHoxVld3ZkhXbFJaczg4MEE4TVJjSSt4ekYw?= =?utf-8?B?bWVpTDJjVlpzd3FYMUsvSWNOZlRISWV3U3EvcWZGZmdhNWRGRkJQVjA3Z2ZS?= =?utf-8?B?bkhvdkEvVm5UYnhGQnhpUGVGa1ozekFjVU5GYXVhQUxTZmhRejdsUlBMWTdB?= =?utf-8?B?VHViVEkyU1BmZUpHWHJSbGhicFZqeENLRXF5OTVTdFBMSFJ4TFB4NCszSkRv?= =?utf-8?B?Q2xKRGRPOG1LZSt4RkN6MFZQTFA3dmsyYXBNTVBXT0tURnpxK2Y3a00xN2hE?= =?utf-8?Q?EO/I3mJFephCjTM8QryrlV?= X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB012;5:qIKAuJzbzklU4+F77I8NYANhjkDfrL8FrBBaXnjrGtzXzy2Jd9kL6F3JlUaquCV9/TFCSlM/ZcRvdNeK+9voALngDn3MBXpU/yenj70s0Bgxg7DR8ADVmVCcbglEOZKO29nNmaQJezn9AVBsaHzZ0g==;24:ap7QsyMOztiTWZjku3aQET2vrqtw9jGTEimnJmzPh55xMm54+haTW96RUaywJrvaRsdZAx+KMCn3MWu7sNjk4cGPnOzh7veg1HPnc5UJxHU= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2015 16:33:22.4977 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB012 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-10-22 at 10:16AM +0530, Kedareswara rao Appana wrote: > Simply resetting the peripheral on bus off condition is not enough, > Because we also need to re-initialize the whole device. > This patch fixes this issue. > > Signed-off-by: Kedareswara rao Appana > --- > drivers/net/can/xilinx_can.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c > index 055d6f3..9aeb85f 100644 > --- a/drivers/net/can/xilinx_can.c > +++ b/drivers/net/can/xilinx_can.c > @@ -529,6 +529,8 @@ static int xcan_rx(struct net_device *ndev) > return 1; > } > > +static void xcan_chip_stop(struct net_device *ndev); Isn't it possible to move the function and avoid the forward declaration? Sören