From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S966071AbbJVXfz (ORCPT <rfc822;w@1wt.eu>);
	Thu, 22 Oct 2015 19:35:55 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60065 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S966022AbbJVXfR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 22 Oct 2015 19:35:17 -0400
Date: Fri, 23 Oct 2015 01:47:24 +0900
From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Lee Jones <lee.jones@linaro.org>,
        Alexandre Courbot <gnurou@gmail.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <20151022164724.GZ8232@sirena.org.uk>
References: <1443731874-21362-1-git-send-email-afd@ti.com>
 <1443731874-21362-5-git-send-email-afd@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="5FDiZl1vRbLRjwwc"
Content-Disposition: inline
In-Reply-To: <1443731874-21362-5-git-send-email-afd@ti.com>
X-Cookie: Does not include installation.
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: 211.36.156.43
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH v4 4/5] regulator: tps65912: Add regulator driver for the
 TPS65912 PMIC
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--5FDiZl1vRbLRjwwc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 01, 2015 at 03:37:53PM -0500, Andrew F. Davis wrote:

> +static const struct of_device_id tps65912_regulator_of_match_table[] = {
> +	{ .compatible = "ti,tps65912-regulator", },
> +	{ /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, tps65912_regulator_of_match_table);

Does this IP block exist outside of the tps65912?  If not why is it
directly represented in DT?  It seems like this is describing how Linux
loads drivers not how the hardware is constructed but DT should describe
the hardware.

--5FDiZl1vRbLRjwwc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWKRMcAAoJECTWi3JdVIfQSHYH/0HgOh93Kz9laCFWEjnU7LCy
cYbTBuyM+ES5KjHtXXt/TVbqN06rfZDpC8efLd+cBGtLvpAPGeLmDjO1Ofsp0Da3
vUKdNAICwoPe6WzI4UEic7X7JS7JQQo97CYKkH/bcRC6IlsGnlMn2G8fwt8vFCSP
ARyy2/3vzKhwhdvbbdwLfYIl2Fqe1WIzrlHUcdrIE8GC8GxKvdkRAN9Ss4tNL/54
AH2xGWvQlMehu9lqWKXou2HySJdavQNjZdP5ePxi8MQ+qzMtM1EP5URBWBQRXNkL
UYZLE/iIMjG4LV+H/D6OS3YoMNH93NTKw+BAgv1lgb68ocS86TbS3cdSMN4c0Rc=
=kzM9
-----END PGP SIGNATURE-----

--5FDiZl1vRbLRjwwc--