From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966132AbbJVXgr (ORCPT ); Thu, 22 Oct 2015 19:36:47 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60154 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966119AbbJVXgn (ORCPT ); Thu, 22 Oct 2015 19:36:43 -0400 Date: Fri, 23 Oct 2015 01:50:17 +0900 From: Mark Brown To: Sugar Zhang Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, heiko@sntech.de, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20151022165017.GA8232@sirena.org.uk> References: <1444308009-29088-1-git-send-email-sugar.zhang@rock-chips.com> <1444308009-29088-3-git-send-email-sugar.zhang@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="azskX66S5GHWoEK7" Content-Disposition: inline In-Reply-To: <1444308009-29088-3-git-send-email-sugar.zhang@rock-chips.com> X-Cookie: Does not include installation. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 211.36.156.43 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 2/3] Documentation: DT bindings: rockchip-i2s: add capture property X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --azskX66S5GHWoEK7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 08, 2015 at 08:40:08PM +0800, Sugar Zhang wrote: > +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt > @@ -21,6 +21,7 @@ Required properties: > - clock-names: should contain followings: > - "i2s_hclk": clock for I2S BUS > - "i2s_clk" : clock for I2S controller > +- rockchip,capture-channels: max capture channels, if not set, 2 channels default. If this can not be set then it's an optional property, not a required property, and should be in the optional properties section. Please send a followup patch fixing that. --azskX66S5GHWoEK7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWKRPIAAoJECTWi3JdVIfQFawH/2WohZEj2f9LB1ZNFWeGJcv3 Q3NsU6A88hcDC69WDlKFDl3fsbPKaeos5/J7u24iefFNvuubK1D/l42QDkJLQ00U WgWqLHnqKOfZAb5OdVP8oq115RRYr+n+V+7FrkJgCWlH/mguYQWNyRO1D/iqF16s I+a/7d+2RC/AEM94rIpU20qpT7PFR3R2mfWnF5wHqMKwF+qscs120ljaVlmuthg+ OtzFkurCC2hLJQunU67bIyvFP7iJfvQbUugrsKdBPTCSsh6EtPrkcAaNE4k/Fz29 lytAIo0SOpg0r8K3rdQ+o9GyEiw+0IZQaaUP5WE8XlDQTlELKXML8IwnW34OOjw= =R90i -----END PGP SIGNATURE----- --azskX66S5GHWoEK7--