From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965432AbbJVTOY (ORCPT ); Thu, 22 Oct 2015 15:14:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39535 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753141AbbJVTOX (ORCPT ); Thu, 22 Oct 2015 15:14:23 -0400 Date: Thu, 22 Oct 2015 12:14:22 -0700 From: Greg KH To: punit vara Cc: Larry Finger , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Julia Lawall , Sudip Mukherjee , Dan Carpenter Subject: Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test Message-ID: <20151022191422.GA26818@kroah.com> References: <1444847155-11243-1-git-send-email-punitvara@gmail.com> <1444847155-11243-5-git-send-email-punitvara@gmail.com> <20151017051635.GA3074@kroah.com> <20151019020020.GB8496@kroah.com> <56245902.7070202@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: > On Mon, Oct 19, 2015 at 8:51 PM, punit vara wrote: > > On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger wrote: > >> On 10/18/2015 09:00 PM, Greg KH wrote: > >>> > >>> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: > >>>> > >>>> One more thing I would like suggestion how can start switching this > >>>> driver to LIB80211 ,MAC80211 ? Which is the first file I should focus > >>>> ? Simultaneously I am trying to understand the flow of driver . I > >>>> would like to know the start point from where I can start doing small > >>>> changes. > >>> > >>> > >>> If you don't understand the wireless stack, I suggest you do some > >>> research on it first, converting a driver to the in-kernel stack is a > >>> _very_ difficult thing and not something that someone without any > >>> experience in this area is going to be able to do easily. > >> > >> > >> I second this suggestion. Your skill level is not nearly sufficient for this > >> sort of task. Note that there is a group working on driver rtl8192su, which > >> should be able to replace rtl8712u. The participants are very highly skilled > >> wireless developers; however, they are having trouble. The internals of the > >> Realtek chips are not revealed to anyone in any form other than the code > >> they release. > >> > >> Larry > >> > >> > > > > > > Thank you Larry ,Tillman , Greg for your valuable suggestions. I am > > interested to learn wireless stack .I have already read wireless wiki > > documentation , sort of rtl8712 code , cfg80112 APIs . Yeah I agree > > with you Greg and Larry that its _very_ difficult to thing to convert > > driver in kernel and also rtl8712 has more files compare to others. > > Anyway however difficult or tough it may be but I have to go through > > it once to become highly skilled or good engineer . I would give it a > > try even if I will fail I believe at least 1% of my knowledge will be > > improved . More suggestions are welcome. > > > > I have did > > > > git remote add gregkh > > http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > > > git pull gregkh > > > > git rebase my_local_branch > > > > I have got some conflicts .I can solve them but they are too many . I > > am trying to solve it . After that I will soon resend this patch. > > > > Thanks > > @Greg KH > I am working on linux-next .I have tried to rebase my local branch on > your staging tree but I am getting too many conflict .and I have tried > to clone your staging tree separately but due slow internet I am > unable to clone it fully . Is there any other way I can get your > staging tree by downloading ? git.kernel.org is the only location, sorry. Try starting with a "clean" version of Linus's tree and just add a branch for my tree, it should be quite a small download. greg k-h