From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751977AbbJWDUH (ORCPT ); Thu, 22 Oct 2015 23:20:07 -0400 Received: from mail-bn1bn0105.outbound.protection.outlook.com ([157.56.110.105]:26000 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750911AbbJWDUF (ORCPT ); Thu, 22 Oct 2015 23:20:05 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Date: Thu, 22 Oct 2015 22:19:52 -0500 From: Scott Wood To: Zhao Qiang CC: , , , , , , Subject: Re: [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc Message-ID: <20151023031952.GA31843@home.buserror.net> References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-6-git-send-email-qiang.zhao@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1444806968-4627-6-git-send-email-qiang.zhao@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: CY1PR0601CA0027.namprd06.prod.outlook.com (25.160.162.37) To BN3PR03MB1478.namprd03.prod.outlook.com (25.163.35.141) X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1478;2:TamlFrbSJ7/lctwA2kDshVrcQ66XTgy05K6Ru7KgRyF9Om0lUX/C0NCKHUfPhl0gwDGmhE2sndXySagtPb9xRT5uQnSGtXsK45Vme26xLAU33WWN6gnmWRYRaTMZDZLTO8Ai07zECMOns0C1pheGSfU0fAm/eBoU825WPfv0iCU=;3:9mI8h7B0ASXqm3J4Q/fEq/gKima4F4kTDdBGqyDUTEkQPF6CFUWtCWWOuNIlIKCpWC4mc9Sz6k7ghTXwYtSFFQKkkxSlgGtO3gIL/W2SQKicT+/WKgcpXVvgY0TikfTMLs9u9lrUmdYI56ljI7Zpxg==;25:Ipv/ZCqe+ii4NwtlZpdpYKquKYJtARDhA9A/Rp8goAFgH/oDWdUgKqqBzXeZK8bPp6xjfzRwuSsrMaA9cxQka649u5UF7cFI+oxPa65usCoerWGkVM9NXkntIL55MXjDgMzi0bfzRzSVW36iJBXVTol05GSSEZwHSa7Pa0P1B1iEpnwI9+0dtpSUwjVAf+NFFjIVF3cvZUi3XsadmGKomkkJYq1qfy/LnYIjQLmCSJI5aHgf+wentDj9gLPQwsTG X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1478; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1478;20:aRIosaq5m22BIoCK38H4NmFru82WpqMEhqx/R6JuS4NBoBiLg7q3cjCHpCOnq1eBG0hj+mKJcPpSka5edUCxm/OPadrB86CHN0QhZIauPeCMIHhhJXvhEzuxkQtHDHftn+lEgi3alfN/KvKnBgwBxJjYzlEsRQwfCPjEw64mDQ089mJ0gENeElOHpcf3OIknXTspnYQJfDOEZK4cbomL2qh/rDaF3xvAevQJ2nuOUiBc+iTXwtq0nXRhE/qgRufRX+KKlzHeV0w2XfR3HrkbiHCUdgLcmDZL/R9BSzdvR2OEGyfl01lq1x3DFA87CBW3EFej5D3GwGmosy3vmMPW0mpwQv9xJIzzw8A4uPLKZjXMicU1O1ybFEu65eXrNoeQie+Q0jmYrAsgF3W0VllP5k9hQ6Z7TveXu3lWdYcK77Fu29xyVgvFJrXMYctGk95tM78k612H0peSMDyi/hjtsYLPvwvhpDzhzoqkNLfHROe5fDqDOyLchBKnXwTPElwj;4:a/MnpsDlk/Oc8SyXZNOind9/B0Bz+w6ZFfvVMrKRyaiahOFytjAjmTEqqp2FTqku9CEd1KIOt3y834OF3a9ogxASyRoz3GGpqGRVzBN61V5I7ZI3bGyR1gw4UdZQ90/8evLfzGKWG58mcep5TSGG2Yx9BJwsyVyhWiikxxAPlFc4tXfOsPGl0c5BdWVtG/Y/JQW5lFgLMEmG0C40lDfQo0lILvigJFNfEKC69nVaUhwsH4oTGseMvNHcLKpkmyGRvCqy86Z/WBiAZ6NHlIN9QXcWCbAEMZYpezrL33fJjkAh0l+ZoK6IcFKiSf0Yr+2CvTY2PTXN99Kg6Cy0U9gqmyBe9Gcpd/viSUtCMXorsWM4eiJvZ/QrCVaYCPhSz/em X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(102215026);SRVR:BN3PR03MB1478;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1478; X-Forefront-PRVS: 0738AF4208 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(199003)(189002)(50986999)(23726002)(5004730100002)(42186005)(97756001)(53416004)(69596002)(47776003)(4001350100001)(66066001)(2950100001)(50466002)(33656002)(97736004)(5007970100001)(76176999)(81156007)(110136002)(189998001)(5001960100002)(86362001)(87976001)(77096005)(5008740100001)(106356001)(575784001)(92566002)(83506001)(105586002)(54356999)(122386002)(46406003)(40100003)(4001450100002)(101416001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR03MB1478;H:home.buserror.net;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR03MB1478;23:CmKm3vNQDfHnQ/pVr8qYBOqphx0VKjFTBb43pLCKt?= =?us-ascii?Q?KJSjfEPqUa7Klq3iTdqysjwhEpiep+dSZAA3CiHKjMZvPjOcTkbzHjCQ+lf3?= =?us-ascii?Q?906mJUPH3JG6K76PshC/1exbWSojyWpoG3xPzsxQ/9S8OxV5Svudono7nHpL?= =?us-ascii?Q?BySQNUAxKEG5cFAmoN7qVEYst2I0Iylw4S3OFzWzL3qgp9/eqUmaiR5sP7Y9?= =?us-ascii?Q?lSZKjJNaEvznlnNYm92qnkWgDjx16p2e9xtQ+Wb26wjZXrZE3wnW7bUab6Zw?= =?us-ascii?Q?FWCfGCGhYHfV+aMxxYhauD3VtiT64M9ajniDrvfaUBMis4k5NhRH1NfIzgZt?= =?us-ascii?Q?tkQBoZpUjW8gU/EN5BRMLlwuP7fQts27yf/ygtXa0ZpsOTn1GwmMmTV8GTPF?= =?us-ascii?Q?tMbrdq5HYMI3SWcZ7KTasCOcKwU7gIHibCnE03bJlkd9YzpWZSBpT+bNVMTd?= =?us-ascii?Q?EPTJAUoS2DaF0evNXOSCLxlSjm70qqv97KsSmdm7TsE4fomZwET1sHHq8/Eg?= =?us-ascii?Q?5AUqr7g56vg9Hbfu12Y3r8CICpGo+/nzX8Xp7wHjzLI5ghgsJoKbvf8/tRoj?= =?us-ascii?Q?56eUyCb6Leci+mWeIk0m7L69Z4pnA5XJjAI+HcKDhPFz+Pt1sqHE7bz9mUuD?= =?us-ascii?Q?nNAXe17oqJvJ8Fq9Wm8ROiRN2VjWJeJU7OFR3tv22O19k79+LyChGg3Rb38g?= =?us-ascii?Q?A7F4+oZhrvbsjKWIhigstnixbo/JIUt3LVKta4/SZjGlgR8rWLCuda3MJgFA?= =?us-ascii?Q?XndRrQr4a5BqhHtgbNZ67Vw03Q7e8T9WGJb8zL2vYxIDBUojO9MLYA9VKwkC?= =?us-ascii?Q?qyFpMdL8KsE0jOK++YSZ+nzxDy5ygNFlIVt/RwK7jrcEx3GZrXHkpOxVqbu6?= =?us-ascii?Q?BuDCko+MawLy1i98yY13s7oHOG38Cg79fH7zIZ7mRKfXiISZzXwh3P1xQ0sm?= =?us-ascii?Q?ypPUia3Ui1wg6Oq6CfwelpAzv/doa5k3W9nDuGMUNPI2Z6uj9ZcylNRqx3me?= =?us-ascii?Q?GmgcBwxr3IA/dFcfW+CjpSIy2iVllaX4OEkdUzO+YYFVni8bkOqZWBrmSiPp?= =?us-ascii?Q?9mt1nHTaSB9tHEJfrt4b5AlUYz4?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1478;5:1NLXukT4zCow+toW5gDUaQfWUMolYUwgM/sjQUcN6sIUUi2dHke5M06r2v1By7qLx+GiUNRg7qY8IAGjOPwvRcAK3cfreoBhjMBgaEAiXP3oLsslI5Ai5MY4rkD1owHjxWa/SuhUJhljjUPUq2Vd7w==;24:r2elfThZmluKdE43U7+H3kNLE3zHRFdRhHOaWxP/IXURk7KiK9c0RLtP994F3hfNxQDC4BOC9g7Fv+GqE2Mn9M8t3BUHy1pr79qyN/0kaXM=;20:OKB0C1TVUC1RLg9VH4zKPXBNPTklH2g2BqicTkt1GbDEt/T+Ose8YzEN8jamAL3vT9HqjZjF9vhgBH0lf8z86Q== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2015 03:20:01.0756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1478 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2015 at 03:16:08PM +0800, Zhao Qiang wrote: > diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig > index 01626be7..c9541a5 100644 > --- a/arch/powerpc/platforms/Kconfig > +++ b/arch/powerpc/platforms/Kconfig > @@ -272,25 +272,6 @@ config TAU_AVERAGE > > If in doubt, say N here. > > -config QUICC_ENGINE > - bool "Freescale QUICC Engine (QE) Support" > - depends on FSL_SOC && PPC32 > - select GENERIC_ALLOCATOR > - select CRC32 > - help > - The QUICC Engine (QE) is a new generation of communications > - coprocessors on Freescale embedded CPUs (akin to CPM in older chips). > - Selecting this option means that you wish to build a kernel > - for a machine with a QE coprocessor. > - > -config QE_GPIO > - bool "QE GPIO support" > - depends on QUICC_ENGINE > - select ARCH_REQUIRE_GPIOLIB > - help > - Say Y here if you're going to use hardware that connects to the > - QE GPIOs. Why was QE_GPIO moved as part of this patch? > diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/drivers/soc/fsl/qe/Kconfig > similarity index 50% > copy from arch/powerpc/sysdev/qe_lib/Kconfig > copy to drivers/soc/fsl/qe/Kconfig > index 3c25199..283fe0d 100644 > --- a/arch/powerpc/sysdev/qe_lib/Kconfig > +++ b/drivers/soc/fsl/qe/Kconfig > @@ -2,6 +2,17 @@ > # QE Communication options > # > > +config QUICC_ENGINE > + bool "Freescale QUICC Engine (QE) Support" > + depends on FSL_SOC && PPC32 > + select GENERIC_ALLOCATOR > + select CRC32 > + help > + The QUICC Engine (QE) is a new generation of communications > + coprocessors on Freescale embedded CPUs (akin to CPM in older chips). > + Selecting this option means that you wish to build a kernel > + for a machine with a QE coprocessor. > + > config UCC_SLOW > bool > default y if SERIAL_QE > @@ -19,9 +30,3 @@ config UCC_FAST > config UCC > bool > default y if UCC_FAST || UCC_SLOW > - > -config QE_USB > - bool > - default y if USB_FSL_QE > - help > - QE USB Controller support Why did some config symbols get moved and others not? > diff --git a/drivers/soc/fsl/qe/Makefile b/drivers/soc/fsl/qe/Makefile > new file mode 100644 > index 0000000..51c9dce > --- /dev/null > +++ b/drivers/soc/fsl/qe/Makefile > @@ -0,0 +1,9 @@ > +# > +#Makefile for the Linux fsl parts of QE > +# "fsl parts of QE"? Are there non-fsl parts of QE? -Scott